Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error using vscode Tasks presentationOptions reveal #9239

Closed
brianignacio5 opened this issue Mar 23, 2021 · 1 comment · Fixed by #9248
Closed

Error using vscode Tasks presentationOptions reveal #9239

brianignacio5 opened this issue Mar 23, 2021 · 1 comment · Fixed by #9248
Labels
bug bugs found in the application tasks issues related to the task system

Comments

@brianignacio5
Copy link

brianignacio5 commented Mar 23, 2021

Bug Description:

Trying to test a vscode extension in Theia but get some errors with vscode.Task.PresentationsOptions.reveal. As I understand, this is already covered by Theia in VSCode API coverage.

Steps to Reproduce:

  1. In visual studio code extension, use the vscode.task API to create a task.
  2. Try to update myTask.presentationOptions.reveal = vscode.TaskRevealKind.Always;
  3. Get an error that can't update reveal of undefined

vscode extension code

public static addTask(
    taskDefinition: vscode.TaskDefinition,
    scope: vscode.TaskScope,
    name: string,
    execution:
      | vscode.ShellExecution
      | vscode.ProcessExecution
      | vscode.CustomExecution,
    problemMatchers: string | string[],
    revealTask: vscode.TaskRevealKind
  ) {
    const newTask: vscode.Task = new vscode.Task(
      taskDefinition,
      scope,
      name,
      ESP.extensionID,
      execution,
      problemMatchers
    );
    newTask.presentationOptions.reveal = revealTask; // Error here
 }

I believe its an issue with the new vscode.Task() constructor not initializing it.

Additional Information

  • Operating System: macOS Catalina 10.15.7
  • Theia Version: next (using a browser app)
    List of extensions
    @theia/bulk-edit 1.12.0-next.1a1d7afc
    @theia/callhierarchy 1.12.0-next.1a1d7afc
    @theia/console 1.12.0-next.1a1d7afc
    @theia/core 1.12.0-next.1a1d7afc
    @theia/debug 1.12.0-next.1a1d7afc
    @theia/editor 1.12.0-next.1a1d7afc
    @theia/file-search 1.12.0-next.1a1d7afc
    @theia/filesystem 1.12.0-next.1a1d7afc
    @theia/markers 1.12.0-next.1a1d7afc
    @theia/messages 1.12.0-next.1a1d7afc
    @theia/mini-browser 1.12.0-next.1a1d7afc
    @theia/monaco 1.12.0-next.1a1d7afc
    @theia/navigator 1.12.0-next.1a1d7afc
    @theia/outline-view 1.12.0-next.1a1d7afc
    @theia/output 1.12.0-next.1a1d7afc
    @theia/plugin-dev 1.12.0-next.1a1d7afc
    @theia/plugin-ext 1.12.0-next.1a1d7afc
    @theia/plugin-ext-vscode 1.12.0-next.1a1d7afc
    @theia/preferences 1.12.0-next.1a1d7afc
    @theia/preview 1.12.0-next.1a1d7afc
    @theia/process 1.12.0-next.1a1d7afc
    @theia/scm 1.12.0-next.1a1d7afc
    @theia/search-in-workspace 1.12.0-next.1a1d7afc
    @theia/task 1.12.0-next.1a1d7afc
    @theia/terminal 1.12.0-next.1a1d7afc
    @theia/timeline 1.12.0-next.1a1d7afc
    @theia/userstorage 1.12.0-next.1a1d7afc
    @theia/variable-resolver 1.12.0-next.1a1d7afc
    @theia/workspace 1.12.0-next.1a1d7afc
@vince-fugnitto vince-fugnitto added bug bugs found in the application tasks issues related to the task system labels Mar 23, 2021
@alvsan09
Copy link
Contributor

Hi,
I am looking into this issue,
I will be posting a pull request shortly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs found in the application tasks issues related to the task system
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants