Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filtering in Tree Widgets and Improving Tree Search #8380

Closed
colin-grant-work opened this issue Aug 13, 2020 · 0 comments · Fixed by #8540
Closed

Filtering in Tree Widgets and Improving Tree Search #8380

colin-grant-work opened this issue Aug 13, 2020 · 0 comments · Fixed by #8540
Labels
enhancement issues that are enhancements to current functionality - nice to haves help wanted issues meant to be picked up, require help tree issues related to the tree (ex: tree widget)

Comments

@colin-grant-work
Copy link
Contributor

Feature Description:

VSCode has added the ability to filter on a search term in a tree widget. This would be a very nice addition to Theia's existing TreeSearch functionality.

vscode-filter

In addition, it would be desirable to allow greater customization of the behavior of TreeSearch. For example, if a downstream project would like to implement a persistent filter component as part of a TreeWidget, it is made difficult because of assumptions made in the current implementation: the TreeIterator used in TreeSearch sets pruneCollapsed to true, so that any change in expansion requires a recalculation of searchDecorations for the tree. Changing that behavior requires a reimplementation of the entire TreeSearch.filter() method, and there are similar hurdles to other customizations.
@vince-fugnitto vince-fugnitto added enhancement issues that are enhancements to current functionality - nice to haves help wanted issues meant to be picked up, require help tree issues related to the tree (ex: tree widget) labels Aug 13, 2020
@vince-fugnitto vince-fugnitto mentioned this issue Aug 13, 2020
Closed
@colin-grant-work colin-grant-work mentioned this issue Sep 21, 2020
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement issues that are enhancements to current functionality - nice to haves help wanted issues meant to be picked up, require help tree issues related to the tree (ex: tree widget)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Filter button in search box colin-grant-work/theia
2 participants
@vince-fugnitto @colin-grant-work