Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Starting all plugins when closing the workspace looks strange #7895

Closed
lmcbout opened this issue May 26, 2020 · 1 comment
Closed

Starting all plugins when closing the workspace looks strange #7895

lmcbout opened this issue May 26, 2020 · 1 comment
Labels
plug-in system issues related to the plug-in system question user / developer questions

Comments

@lmcbout
Copy link
Contributor

lmcbout commented May 26, 2020

Bug Description:

When you close a workspace, we can observe on the console that we start all plugins.
Should we just activate the plugins when we open a workspace? It looks weird to see the traces about all started plugins when you close a workspace.

Note: comes from the discussion #7885

Steps to Reproduce:

  1. Start Theia with a workspace
  2. Close the workspace, not Theia (File-> Close Workspace)
    --> Observe the traces on the console, all plugins get started

Additional Information

  • Operating System: Ubuntu 18.04
  • Theia Version: Latest
@akosyakov
Copy link
Member

That's expected: close workspace reloads the window, plugins are reloaded for a new window, a empty workspace needs plugins as well, since you still can open a file or a plugin can contribute an action to create a new project.

@akosyakov akosyakov added plug-in system issues related to the plug-in system question user / developer questions labels May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plug-in system issues related to the plug-in system question user / developer questions
Projects
None yet
Development

No branches or pull requests

2 participants