Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

windowState not saving anymore. #7811

Closed
owlJaeger opened this issue May 13, 2020 · 0 comments · Fixed by #7803
Closed

windowState not saving anymore. #7811

owlJaeger opened this issue May 13, 2020 · 0 comments · Fixed by #7803
Labels
bug bugs found in the application electron issues related to the electron target

Comments

@owlJaeger
Copy link
Contributor

owlJaeger commented May 13, 2020 •
edited
Loading

Bug Description:

Due to #7787 the windowState is not saving anymore. I am sorry, I've noticed that before it was merged and reviewed my own code to mention it, but that review was only visible to me somehow and thus noone read it and it was merged. My alternative PR #7803 doesn't have that problem and also reverts #7787. It should get merged as client's lose windowState storing.

Steps to Reproduce:

  1. Open Theia
  2. Maximize Theia
  3. Close Theia
  4. Open Theia
  5. Window not maximized as it should be when closing it in the maximized-state

Additional Information

  • Operating System: Probably all
  • Theia Version: 1b0b6d9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug bugs found in the application electron issues related to the electron target
Projects
None yet
Milestone
No milestone
2 participants
@akosyakov @owlJaeger