Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown Language Features (built-in) version 1.44.2 report an error in Theia #7780

Closed
lmcbout opened this issue May 8, 2020 · 2 comments
Closed
Labels
builtins Issues related to VS Code builtin extensions markdown issues related to markdown vscode issues related to VSCode compatibility

Comments

@lmcbout
Copy link
Contributor

lmcbout commented May 8, 2020

Bug Description:

When you upgrade the Markdown Language Features (built-in) version from version 1.39.1 to version 1.44.2, opening a README.md file does not show

An error is reported:
failed: n.window.registerCustomEditorProvider is not a function.

Steps to Reproduce:

  1. Update package,json with
    FROM
    "vscode-builtin-markdown-language-features": "https://open-vsx.org/api/vscode/markdown-language-features/1.39.1/file/vscode.markdown-language-features-1.39.1.vsix",
    TO
    "vscode-builtin-markdown-language-features": "https://open-vsx.org/api/vscode/markdown-language-features/1.44.2/file/vscode.markdown-language-features-1.44.2.vsix",
  2. Remove the plugins folder
    3.yarn download:plugins
  3. Start Theia with a workspace pointing to Theia
  4. In the explorer view, locate a README.md file
    Select Context menu/Open With/ Preview
    --> DO NOT WORK with builtin 1.44.2
    --> work with builtin 1.39.1

Additional Information

  • Operating System: UBUNTU 18.04
  • Theia Version: LATEST
@vince-fugnitto
Copy link
Member

@lmcbout the API has been recently marked as final and is not yet supported: #6636

@vince-fugnitto vince-fugnitto added the builtins Issues related to VS Code builtin extensions label May 8, 2020
@akosyakov akosyakov added markdown issues related to markdown vscode issues related to VSCode compatibility labels May 11, 2020
@vince-fugnitto
Copy link
Member

I tested with 1.50.0 of the extension and it works well given that registerCustomEditorProvider is implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builtins Issues related to VS Code builtin extensions markdown issues related to markdown vscode issues related to VSCode compatibility
Projects
None yet
Development

No branches or pull requests

3 participants