Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Plugin-Api] Apply authentication API #7661

Closed
vinokurig opened this issue Apr 24, 2020 · 3 comments
Closed

[Plugin-Api] Apply authentication API #7661

vinokurig opened this issue Apr 24, 2020 · 3 comments
Assignees
@vinokurig
Labels
help wanted issues meant to be picked up, require help plug-in system issues related to the plug-in system vscode issues related to VSCode compatibility

Comments

@vinokurig
Copy link
Contributor

Apply authentication VsCode Plugin API. Is needed for vscode-github-pr-plugin authentication.

Feature Description:

VsCode implementation: https://github.com/microsoft/vscode/blob/ab42ffc44c709aded523b15399a070ae8c724824/src/vs/vscode.proposed.d.ts#L98-L131
@vinokurig vinokurig added plug-in system issues related to the plug-in system vscode issues related to VSCode compatibility labels Apr 24, 2020
@akosyakov akosyakov added the help wanted issues meant to be picked up, require help label Apr 24, 2020
@akosyakov
Copy link
Member

That's still a proposed API: microsoft/vscode#88309

@vinokurig vinokurig mentioned this issue Jun 9, 2020
Closed
@vinokurig vinokurig self-assigned this Jul 27, 2020
@vinokurig
Copy link
Contributor Author

The Github PR plugin already uses it in last 3 releases: https://github.com/microsoft/vscode-pull-request-github/blob/ea819cdf03e49322d2eaf0b81edcf0098f5986b3/src/github/credentials.ts#L52

This was referenced Jul 27, 2020
Closed
Closed
@ericwill ericwill mentioned this issue Aug 20, 2020
Closed
32 tasks
@vinokurig
Copy link
Contributor Author

Is fixed by #8402

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vinokurig vinokurig

Labels
help wanted issues meant to be picked up, require help plug-in system issues related to the plug-in system vscode issues related to VSCode compatibility
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@akosyakov @vinokurig