-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nsfw build error: 'ThreadSafeFunction': is not a member of 'Napi' #7510
Comments
Thank you for the issue, I think it might be better to open the issue directly in theia-apps. I haven’t verified myself (if it is reproducible from sources in the main repository) but you may want to take a look at the project’s prerequisites which may prove to be useful: |
I can confirm this. I hit the same issue today in a downstream project after wiping the
@JanKoehnlein had the same issue today. So if anyone who is interested in a workaround; you should copy the |
"resolutions": {
"**/**/nsfw": "1.2.7"
}, in package.json should fix the issue |
I confirmed it worked in a downstream project (fresh from the generator). |
cc @azatsarynnyy Maybe it has to do something with ARM's fix in nsfw? :) |
not sure issue is for @azatsarynnyy but more for @arekzaluski |
@akosyakov @benoitf @vince-fugnitto I don't think that this issue is caused by our change in nsfw (fixing the rename events on Windows). It is most likely due to the Napi refactor in release |
If it's within your power you might want to consider upgrading to Node 10.16.0 or higher. |
I think it would be sensible to keep the node version inline with the version used in the electron we support. Currently, on Electron 4.x we have node 10.11.0. |
I've tried building again and now no workaround is needed to build it without errors. Seems to be fixed, closing this issue |
I am getting nsfw build error in Ubuntu 22.04.1 LTS [4/4] Building fresh packages... |
EDIT: SOLVED - The problem was with the pathname to the repo; my hard drive had a space in its name, which was not being escaped by the build process. I've renamed the hard drive by omitting the space, and it now runs beautifully. I am currently getting an nsfw error, as well. This occurs with a fresh clone of /theia, and also /theia-blueprint. OS: MacOS 12.6 Monterey Steps to reproduce:
I've tried with both node 16.19.0, and 19.2.0, and yarn 1.32.x [4/10] ⡀ nsfw |
Description
Building the nsfw package throws node-gyp error.
Example: ('ThreadSafeFunction': is not a member of 'Napi')
Reproduction Steps
yarn
OS and Theia version:
@theia/core: 1.0.0
Tested on:
Windows 10 version 2004 (Build 19041.vb_release.191206-1406)
Ubuntu 19.10
Diagnostics:
log.txt
The text was updated successfully, but these errors were encountered: