Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[editor] chinese input method error #6459

Closed
502647092 opened this issue Oct 29, 2019 · 2 comments · Fixed by #6673
Closed

[editor] chinese input method error #6459

502647092 opened this issue Oct 29, 2019 · 2 comments · Fixed by #6673
Labels
bug bugs found in the application help wanted issues meant to be picked up, require help monaco issues related to monaco

Comments

@502647092
Copy link
Contributor

Description

at theia when I input at input method then backspace it some thing at editor will clear
temp

I test at monaco don't have this bug
temp

Reproduction Steps

see gif
OS and Theia version:
Diagnostics:

@akosyakov akosyakov added 🤔 needs more info issues that require more info from the author bug bugs found in the application monaco issues related to monaco and removed 🤔 needs more info issues that require more info from the author labels Oct 30, 2019
@monaka
Copy link
Contributor

monaka commented Nov 6, 2019

I got the almost same issue on Che-Theia with ChromeOS/Japanese input method.

I suspect the root cause is "Current Theia doesn't care about KeyCode.KEY_IN_COMPOSITION."
This will be not the issue of Monaco but Theia.
I found the similar issue report in VSCode and there looks be fixed by microsoft/vscode#40546.

I guess there needs some more code in packages/core/src/browser/widgets/widget.ts or near.

@monaka
Copy link
Contributor

monaka commented Nov 6, 2019

gitpod-io/gitpod#875 also will be fixed if this issue was fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs found in the application help wanted issues meant to be picked up, require help monaco issues related to monaco
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants