Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[electron][JSON] Try to reuse node from the PATH instead of process.execPath in electron #5408

Closed
kittaakos opened this issue Jun 10, 2019 · 4 comments
Closed

[electron][JSON] Try to reuse node from the PATH instead of process.execPath in electron #5408

kittaakos opened this issue Jun 10, 2019 · 4 comments
Labels
electron issues related to the electron target json issues related to the json language quality issues related to code and application quality

Comments

@kittaakos
Copy link
Contributor

This issue is a follow up of #5324.

Currently, we always use the process.execPath to lunch the Node.js process for the TS-LS. When running in electron, it means, we use the bundled Node.js runtime instead of the one from the PATH.

For the sake of consistency, we should try to use the node command from the PATH and fall back to the process.execPath. The details are here: #5324 (comment).

Note, the same adjustments have to be used for JSON too.
@kittaakos kittaakos added electron issues related to the electron target quality issues related to code and application quality typescript issues related to the typescript language labels Jun 10, 2019
@kittaakos kittaakos mentioned this issue Jun 10, 2019
Merged
@akosyakov
Copy link
Member

@kittaakos Is it still valid? We don't have ts LS anymore.

@kittaakos
Copy link
Contributor Author

Is it still valid? We don't have ts LS anymore.

Yes. 👇

Note, the same adjustments have to be used for JSON too.

@kittaakos kittaakos added json issues related to the json language and removed typescript issues related to the typescript language labels Mar 18, 2020
@kittaakos kittaakos changed the title [electron][TS] Try to reuse node from the PATH instead of process.execPath in electron [electron][JSON] Try to reuse node from the PATH instead of process.execPath in electron Mar 18, 2020
@akosyakov
Copy link
Member

ok, we have to get rid of JSON then too :)

@kittaakos
Copy link
Contributor Author

I am retiring this issue, @theia/json has been deprecated and removed via #8112.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
electron issues related to the electron target json issues related to the json language quality issues related to code and application quality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kittaakos @akosyakov