Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support vscode task contribution points #4211

Closed
akosyakov opened this issue Feb 1, 2019 · 8 comments · Fixed by #5024
Closed

support vscode task contribution points #4211

akosyakov opened this issue Feb 1, 2019 · 8 comments · Fixed by #5024
Assignees
@elaihau
Labels
enhancement issues that are enhancements to current functionality - nice to haves plug-in system issues related to the plug-in system tasks issues related to the task system vscode issues related to VSCode compatibility

Comments

@akosyakov
Copy link
Member

akosyakov commented Feb 1, 2019 •
edited
Loading

See:

@marcdumais-work it is required to ship built-in VS Code extensions like grunt and gulp
@akosyakov akosyakov added tasks issues related to the task system plug-in system issues related to the plug-in system vscode issues related to VSCode compatibility enhancement issues that are enhancements to current functionality - nice to haves labels Feb 1, 2019
This was referenced Feb 1, 2019
Closed
Closed
@tolusha
Copy link
Contributor

tolusha commented Feb 7, 2019

@akosyakov
Do you mind If I handle this?

@tolusha tolusha self-assigned this Feb 7, 2019
@tolusha
Copy link
Contributor

tolusha commented Feb 7, 2019 •
edited
Loading

I will start from taskDefinistions [1]

[1] https://code.visualstudio.com/api/references/contribution-points#contributes.taskDefinitions

@akosyakov
Copy link
Member Author

@tolusha yes, it is fine with me

I've mentioned @marcdumais-work because I believe there is not support of problemMatchers and problemPatters yet. Since Ericsson team was working on the task extension before, maybe they want to implement support of it as well.

@tolusha
Copy link
Contributor

tolusha commented Feb 8, 2019

I postponed this task for a while.

@tsmaeder tsmaeder mentioned this issue Feb 8, 2019
Closed
20 tasks
@tsmaeder tsmaeder mentioned this issue Feb 27, 2019
Closed
18 tasks
@marcdumais-work
Copy link
Contributor

Hi @tolusha

I postponed this task for a while.

Sorry, I missed this exchange. I hope you did not postpone because of it. I am fine with you working on this, else we will come around to it eventually.

@marcdumais-work
Copy link
Contributor

@tolusha Unless you plan to work on this issue in the very near future, we would like to take-it over and @elaihau would start working on it. Please let us know if you have objections.

@tolusha
Copy link
Contributor

tolusha commented Mar 5, 2019

@marcdumais-work I don't have any objections

@marcdumais-work marcdumais-work assigned elaihau and unassigned tolusha Mar 5, 2019
@tsmaeder tsmaeder mentioned this issue Mar 19, 2019
Closed
22 tasks
@elaihau
Copy link
Contributor

elaihau commented Apr 29, 2019

opened a pr #5024 for this one

@elaihau elaihau mentioned this issue Jun 26, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elaihau elaihau

Labels
enhancement issues that are enhancements to current functionality - nice to haves plug-in system issues related to the plug-in system tasks issues related to the task system vscode issues related to VSCode compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

create problem markers from task output elaihau/theia
4 participants
@tolusha @akosyakov @marcdumais-work @elaihau