Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[plugin] jsonValidation contribution support #3983

Closed
akosyakov opened this issue Jan 9, 2019 · 4 comments · Fixed by #8112
Closed

[plugin] jsonValidation contribution support #3983

akosyakov opened this issue Jan 9, 2019 · 4 comments · Fixed by #8112
Assignees
@akosyakov
Labels
enhancement issues that are enhancements to current functionality - nice to haves plug-in system issues related to the plug-in system vscode issues related to VSCode compatibility

Comments

@akosyakov
Copy link
Member

https://code.visualstudio.com/api/references/contribution-points#contributes.jsonValidation
@akosyakov akosyakov added enhancement issues that are enhancements to current functionality - nice to haves plug-in system issues related to the plug-in system labels Jan 9, 2019
@akosyakov akosyakov mentioned this issue Jan 9, 2019
Closed
@akosyakov akosyakov assigned akosyakov and unassigned akosyakov Jan 9, 2019
@akosyakov akosyakov self-assigned this Feb 1, 2019
@akosyakov akosyakov added the vscode issues related to VSCode compatibility label Feb 1, 2019
@akosyakov akosyakov mentioned this issue Nov 26, 2019
Closed
@vince-fugnitto vince-fugnitto mentioned this issue Jan 17, 2020
Merged
8 tasks
@ShimiT
Copy link

ShimiT commented Mar 11, 2020 •
edited
Loading

@akosyakov Any update on this? contributes.jsonValidation

@akosyakov akosyakov added the help wanted issues meant to be picked up, require help label Mar 11, 2020
@akosyakov
Copy link
Member Author

Not really, if someone sends a PR it would help.

@Livven
Copy link
Contributor

Livven commented Mar 19, 2020

Is this issue still valid with the migration away from Theia-specific language extension to the VS Code ones? I believe this functionality would be provided by the default json-language-features VS Code extension (you can get a prebuilt version here).

Now whether that works is another story (I'm getting a r.languages.registerSelectionRangeProvider is not a function error when opening a JSON file).

@bd82 bd82 mentioned this issue Apr 13, 2020
Closed
1 task
@marcdumais-work
Copy link
Contributor

Now whether that works is another story (I'm getting a r.languages.registerSelectionRangeProvider is not a function error when opening a JSON file).

Hi @Livven , You could try on top of this PR: #6623

@akosyakov akosyakov removed the help wanted issues meant to be picked up, require help label Apr 15, 2020
@akosyakov akosyakov mentioned this issue Jul 1, 2020
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akosyakov akosyakov

Labels
enhancement issues that are enhancements to current functionality - nice to haves plug-in system issues related to the plug-in system vscode issues related to VSCode compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

replace json theia extension with vscode one eclipse-theia/theia
4 participants
@Livven @akosyakov @ShimiT @marcdumais-work