Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-starting the server when two or more workspaces are in a browser generates errors. #2995

Closed
lmcbout opened this issue Sep 27, 2018 · 2 comments · Fixed by #3319
Closed
Assignees

Comments

@lmcbout
Copy link
Contributor

lmcbout commented Sep 27, 2018

Starting Theia in a browser generates errors on the server console
If you start Theia in a browser, it starts ok
If you add a second workspace in the browser, then select again Theia workspace
Note: average loading time is also bad when there is more than one workspace available in a browser and re-starting the server . The secondd workspace could be very little, just a few files in it is enough.

Restart the server and press the refresh button of the browser for Theia workspace, then many errors appears on the server console.
1-
DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

2-
root ERROR TypeScript: (node:24318) UnhandledPromiseRejectionWarning: Error: geterr timeout

3- List of warnings:
root WARN A command _typescript.applyRefactoring is already registered.
root WARN A command _typescript.organizeImports is already registered.
root WARN A command _typescript.applyRenameFile is already registered.
root WARN A command _typescript.applyWorkspaceEdit is already registered.
root WARN A command _typescript.applyCodeAction is already registered.
root WARN A command _typescript.applyRefactoring is already registered.
root WARN A command _typescript.organizeImports is already registered.

@akosyakov akosyakov self-assigned this Oct 1, 2018
@kittaakos
Copy link
Contributor

It is the same the Reconnecting issues.

@akosyakov
Copy link
Member

We should make sure that language servers unregister all commands when disposed and register new on reconnection to get rid of warnings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants