Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove a cycle between application and messaging extensions #250

Closed
akosyakov opened this issue Jun 26, 2017 · 1 comment
Closed

Remove a cycle between application and messaging extensions #250

akosyakov opened this issue Jun 26, 2017 · 1 comment
Assignees
@akosyakov
Milestone
Theia BETA

Comments

@akosyakov
Copy link
Member

  • the application extension provides and uses Logger
  • Logger needs the messaging extension for JSON-RPC bindings
  • the messaging extension uses Event and Disposable from the application extension

One option would be to move the messaging extension under the application extension.
@akosyakov akosyakov self-assigned this Jul 12, 2017
@akosyakov
Copy link
Member Author

It will be fixed in the scope of #59

@svenefftinge svenefftinge added this to the Theia 1.0 BETA milestone Sep 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akosyakov akosyakov

Labels
None yet
Projects
None yet
Milestone
Theia BETA
Development

No branches or pull requests
2 participants
@svenefftinge @akosyakov