Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick pick items with icons issue - Theia 1.47 #13492

Closed
safisa opened this issue Mar 14, 2024 · 3 comments
Closed

Quick pick items with icons issue - Theia 1.47 #13492

safisa opened this issue Mar 14, 2024 · 3 comments

Comments

@safisa
Copy link
Contributor

safisa commented Mar 14, 2024

Bug Description:

Hi,
I have upgraded my Theia extension to the latest 1.47.1 version from 1.45.1, and I got this regression issue when running this command: Terminal --> Run Task...
I think it is related to the quick-pick component.

Here is the issue in screenshots:

Theia (latest 1.47.1):
image

My custom Theia (1.47.1):
image

My custom Theia (1.45.1):
image

The issue does not happen in Theia browser example, only on my Theia, I don't know what is causing it.
Can anyone help and guide me, where and what can I check to fix it?

Thanks in advance

Additional Information

  • Operating System: Mac
  • Theia Version: Theia 1.47.1
@JonasHelming
Copy link
Contributor

It very likely has something to do with the recent Monaco upgrade. #13449 looks related, maybe this helps?

@safisa
Copy link
Contributor Author

safisa commented Jun 7, 2024

@JonasHelming I found that the issue is related to codicon 0.0.27. I saw that the latest Theia is using version 0.0.35, and mine was using 0.0.27, and there was a breaking change in 0.0.28 (Update display property to use inline-block) that causes this issue.
I am not sure why my build did not bring the same codicon version, but once I deleted the yarn.lock file, it brings the latest one. Maybe it is because the Theia core package uses @vscode/codicons: "*" ...

@safisa
Copy link
Contributor Author

safisa commented Jun 7, 2024

you can close this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants