Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Optional Request Tracing #13136

Open
tsmaeder opened this issue Dec 1, 2023 · 0 comments
Open

Introduce Optional Request Tracing #13136

tsmaeder opened this issue Dec 1, 2023 · 0 comments

Comments

@tsmaeder
Copy link
Contributor

tsmaeder commented Dec 1, 2023

Feature Description:

In the course of addressing #12823, I was faced with the error message No reply handler for reply with id: 116. This means that (typically) the back end sent a reply for a request that the current instance of RPCProtocol does not know anything about. Unfortunately, this error message is very unhelpful, because it's impossible to find out what request caused this and whether the request was sent by the same RPCProtocol that the reply got routed to.
My proposal would be to introduce optional tracing messages to our RPC protocol that include:

  1. A globally unique message id (currently, the message id is per RPCProtocol instance
  2. The ID of the sending RPCProtocol instance (or other identifying info about the originator, like service id)
  3. The request that cause the reply. This info could contain a configurable amount of information like
    • the request method
    • the request parameters
    • the stack trace of when the request was sent

Since there will be a performance penalty for this tracing, we should discuss how exactly this tracing could be configured: do we need to be able to turn this on "on the fly" or can it be a cli parameter or even a compile time config?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant