Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode: implement support for file/newFile menu contributions #12755

Closed
vince-fugnitto opened this issue Jul 25, 2023 · 1 comment · Fixed by #12819
Closed

vscode: implement support for file/newFile menu contributions #12755

vince-fugnitto opened this issue Jul 25, 2023 · 1 comment · Fixed by #12819
Assignees
Labels
menus issues related to the menu vscode issues related to VSCode compatibility

Comments

@vince-fugnitto
Copy link
Member

Feature Description:

The goal is to add support for the file/newFile menu path which extension authors can reference when declaring their menu contributions.

The New File item in the File menu and Get Started page - file/newFile

Additional Information

The vscode.ipynb for reference makes use of the menu path:

2023-07-25T18:49:43.379Z root WARN Failed to register a menu item for plugin vscode.ipynb contributed to file/newFile {command: 'ipynb.newUntitledIpynb', submenu: undefined, alt: undefined, group: 'notebook', when: undefined} Error: Could not find submenu with id file/newFile
    at MenuModelRegistry.getMenuNode (http://localhost:3000/bundle.js:147792:23)
    at http://localhost:3000/packages_plugin-ext_lib_hosted_browser_hosted-plugin_js.js:5826:66
    at Array.forEach (<anonymous>)
    at MenusContributionPointHandler.handle (http://localhost:3000/packages_plugin-ext_lib_hosted_browser_hosted-plugin_js.js:5820:37)
    at http://localhost:3000/packages_plugin-ext_lib_hosted_browser_hosted-plugin_js.js:6563:71
    at pushContribution (http://localhost:3000/packages_plugin-ext_lib_hosted_browser_hosted-plugin_js.js:6458:32)
    at PluginContributionHandler.handleContributions (http://localhost:3000/packages_plugin-ext_lib_hosted_browser_hosted-plugin_js.js:6563:9)
    at HostedPluginSupport.loadContributions (http://localhost:3000/packages_plugin-ext_lib_hosted_browser_hosted-plugin_js.js:577:61)
    at HostedPluginSupport.doLoad (http://localhost:3000/packages_plugin-ext_lib_hosted_browser_hosted-plugin_js.js:488:42)
    at async ProgressService.withProgress (http://localhost:3000/bundle.js:151138:20)
@vince-fugnitto vince-fugnitto added vscode issues related to VSCode compatibility menus issues related to the menu labels Jul 25, 2023
@jonah-iden
Copy link
Contributor

Hi, could someone assign me, i'll probably try to implement this later today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
menus issues related to the menu vscode issues related to VSCode compatibility
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants