Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vscode][proposed] dropMetadata proposed API updates for 1.79 #12632

Closed
Tracked by #12613
rschnekenbu opened this issue Jun 21, 2023 · 0 comments · Fixed by #12736
Closed
Tracked by #12613

[vscode][proposed] dropMetadata proposed API updates for 1.79 #12632

rschnekenbu opened this issue Jun 21, 2023 · 0 comments · Fixed by #12736
Assignees
@msujew
Labels
builtins Issues related to VS Code builtin extensions vscode issues related to VSCode compatibility

Comments

@rschnekenbu
Copy link
Contributor

dropMetadata proposed API has evolved between 1.78 and 1.79:

  • DocumentDropEdit now has 2 additional properties: id and priority
  • DocumentDropEditProvider does not have required id property

This proposed API is used by several builtins (ipynb & markdown-language-feature)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@msujew msujew

Labels
builtins Issues related to VS Code builtin extensions vscode issues related to VSCode compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[vscode] Add proposed dropMetadata API eclipse-theia/theia
3 participants
@rschnekenbu @msujew @vince-fugnitto