Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unhandled exception in WorkspaceDeleteHandler#moveFileToTrash #11908

Closed
JonasHelming opened this issue Nov 22, 2022 · 0 comments · Fixed by #12544
Closed

Unhandled exception in WorkspaceDeleteHandler#moveFileToTrash #11908

JonasHelming opened this issue Nov 22, 2022 · 0 comments · Fixed by #12544
Labels
hackathon issues reserved for hackatons

Comments

@JonasHelming
Copy link
Contributor

Blocked for Hackathon

see:

this.fileService.delete(uri, { ...options, useTrash: true });

Consider using 'await' for the promise inside this 'try' or replace it with 'Promise.prototype.catch(...)' usage.
An exception (including reject) thrown by a promise will not be caught by a nesting try block, due to the asynchronous nature of execution. Instead, use catch method of Promise or wrap it inside await expression.

This rule reports try-catch statements containing nothing else but call(s) to a function returning a Promise (thus it’s less likely that catch is intended to catch something else than Promise rejection).

  • Operating System: All
  • Theia Version: Latest

@marcdumais-work Do you want to use this for the Hackathon and add details?

@JonasHelming JonasHelming added the hackathon issues reserved for hackatons label Nov 22, 2022
@marcdumais-work marcdumais-work removed their assignment Dec 13, 2022
@vince-fugnitto vince-fugnitto changed the title Unhandeled exception in WorkspaceDeleteHandler#moveFileToTrash Unhandled exception in WorkspaceDeleteHandler#moveFileToTrash May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hackathon issues reserved for hackatons
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants