Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

theming: tab.activeBorderTop is not applied properly #11616

Closed
vince-fugnitto opened this issue Aug 26, 2022 · 1 comment · Fixed by #11957
Closed

theming: tab.activeBorderTop is not applied properly #11616

vince-fugnitto opened this issue Aug 26, 2022 · 1 comment · Fixed by #11957
Labels
theming issues related to theming

Comments

@vince-fugnitto
Copy link
Member

Bug Description:

The theming option tab.activeBorderTop is not applied properly (notice the missing green border).

theia:

Screen Shot 2022-08-26 at 12 48 52 PM

vscode:

Screen Shot 2022-08-26 at 12 50 14 PM

Steps to Reproduce:

  1. include the following test theme (active-border)
  2. start the application
  3. trigger the command Preferences: Color Theme and select Active Border
  4. open a tab and notice that the border is not applied properly
@vince-fugnitto vince-fugnitto added the theming issues related to theming label Aug 26, 2022
@vince-fugnitto
Copy link
Member Author

The styling does exist but does not seem to work (box-shadow with inset):

theia-main-content-panel .p-TabBar .p-TabBar-tab.p-mod-current {
    color: var(--theia-tab-activeForeground);
    background: #1e1e1e;
    box-shadow: 0 1px 0 #a2ff00, 0 -1px 0 transparent inset;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theming issues related to theming
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant