Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to React 17 #11355

Closed
sdirix opened this issue Jun 28, 2022 · 1 comment
Closed

Update to React 17 #11355

sdirix opened this issue Jun 28, 2022 · 1 comment
Labels
dependencies pull requests that update a dependency file react issues related to the react language

Comments

@sdirix
Copy link
Member

sdirix commented Jun 28, 2022 •
edited
Loading

To stay up to date with our dependencies we should raise the React version Theia is built against. At the moment this is React 16.

Updating to React 17 would make a lot of sense as this would allow gradual updates of React components, i.e. users can integrate multiple versions of React in case they absolutely need to.

For testing we already built Theia against React 17 and did not notice any issue. To my knowledge no deprecated feature of React is used in Theia. As React 17 has barely any changes in the API surface almost all users should be trivially able to update their apps.

We could also update to React 18 but this might be too new for some users integrating libraries which are not compatible to React 18.
@vince-fugnitto vince-fugnitto added react issues related to the react language dependencies pull requests that update a dependency file labels Jun 28, 2022
@vince-fugnitto
Copy link
Member

Closed by #11455.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies pull requests that update a dependency file react issues related to the react language
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sdirix @vince-fugnitto