Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regular translation update #10885

Closed
msujew opened this issue Mar 15, 2022 · 6 comments · Fixed by #11437
Closed

Regular translation update #10885

msujew opened this issue Mar 15, 2022 · 6 comments · Fixed by #11437
Labels
localization issues related to localization/internalization/nls

Comments

@msujew
Copy link
Member

msujew commented Mar 15, 2022

I want to use this issue to have discussions on how to perform regular updates to our translation files.

Proposal

My current idea is to use the CI to create a commit on a separate branch for every commit to master. This branch is always rebased to the latest master and runs the theia nls-extract and theia nls-localize commands to produce updated localization files. These can be merged/cherry-picked into the release-branch and will be then available for every release.

@msujew msujew added the localization issues related to localization/internalization/nls label Mar 15, 2022
@vince-fugnitto
Copy link
Member

I think the idea to have an automated workflow to perform a bulk translation update prior to the release would be the best way forward, cherry-picking a commit isn't the end of the world :) We can also ensure that there is no missing delta between translations if a commit was added afterwards that introduces new localizations.

The issue with having to do it on each pull-request is the fact that the devs would need an API-key to the external service that does the translations, and would likely push new contributors away from the project.

@msujew
Copy link
Member Author

msujew commented Mar 15, 2022

@vince-fugnitto regarding API-keys: I would simply store my API-key as a secret in the GitHub repo, which is then used on every GitHub actions workflow. So, from that perspective, it doesn't matter whether it's on a per-PR or per-release basis, since they use the stored API-key anyway. Contributors to Theia shouldn't have to touch that anyway.

@vince-fugnitto
Copy link
Member

@msujew since we have the free API afaik and we were to do the per pr-basis we might need to check that we do not hit the limit for the month. I assume we should only translate the delta and not the whole codebase again?

@msujew
Copy link
Member Author

msujew commented Mar 15, 2022

@vince-fugnitto the command always works on a delta, since I anticipated this ;)

@vince-fugnitto
Copy link
Member

@msujew I meant to ask you about this item, since we might add new translations during the month (new commands or add missing translations), should we perform a translation before the release (ex: the one scheduled this Thursday)?

@msujew
Copy link
Member Author

msujew commented Jun 27, 2022

@vince-fugnitto Yeah, I will create a PR for this. Didn't have time to take care of this issue (i.e. automatic updates) yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
localization issues related to localization/internalization/nls
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants