Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debug: debug incorrectly imports plugin code #10714

Closed
vince-fugnitto opened this issue Feb 4, 2022 · 1 comment · Fixed by #10718
Closed

debug: debug incorrectly imports plugin code #10714

vince-fugnitto opened this issue Feb 4, 2022 · 1 comment · Fixed by #10718
Labels
debug issues that related to debug functionality plug-in system issues related to the plug-in system quality issues related to code and application quality

Comments

@vince-fugnitto
Copy link
Member

Bug Description:

The pull-request #10163 incorrectly leaks plugin code to @theia/debug.

import * as theia from '@theia/plugin';

No internal extension should explicitly depend on the plugin- system, we should refactor to implement the feature properly.

@tsmaeder was there a specific reason to directly depend on the plugin types from debug?

@vince-fugnitto vince-fugnitto added quality issues related to code and application quality plug-in system issues related to the plug-in system debug issues that related to debug functionality labels Feb 4, 2022
@tsmaeder
Copy link
Contributor

tsmaeder commented Feb 7, 2022

I can't think of a reason right off the bat. Can we just move the class to the theia plugin package? It just seems to be a wrapper around the Theia inline debug adapter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debug issues that related to debug functionality plug-in system issues related to the plug-in system quality issues related to code and application quality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants