Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript's Find All References and other requests are slow when used in this repository #10354

Closed
paul-marechal opened this issue Oct 29, 2021 · 2 comments · Fixed by #10355
Labels
contributor experience issues related to the contributor experience dependencies pull requests that update a dependency file

Comments

@paul-marechal
Copy link
Member

For some reason TypeScript has been taking much more time when responding to requests such as Find All References.

My current guess is that this is due to tsserver@3.9.10 itself being slow, maybe upgrading to @4 will fix it?

@paul-marechal paul-marechal added contributor experience issues related to the contributor experience dependencies pull requests that update a dependency file labels Oct 29, 2021
@msujew
Copy link
Member

msujew commented Oct 29, 2021

@paul-marechal I just tested it by switching between the built-in vscode version of TypeScript and the one used in the project. Running Find All References with @4.4.3 takes 12 seconds, compared to @3.9.10 which takes 75 seconds.

@paul-marechal
Copy link
Member Author

Thanks for the benchmark! I opened a PR to update the TypeScript version we use to build as this is the one we usually recommend people to use for code assistance. Or is it just fine to tell people to use this version bundled with VS Code?

I'd prefer the former, personnally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor experience issues related to the contributor experience dependencies pull requests that update a dependency file
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants