Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add InputBoxOptions#title #10030

Closed
Tracked by #9863
tsmaeder opened this issue Sep 1, 2021 · 2 comments · Fixed by #10920
Closed
Tracked by #9863

Add InputBoxOptions#title #10030

tsmaeder opened this issue Sep 1, 2021 · 2 comments · Fixed by #10920
Labels
good first issue good first issues for new contributors vscode issues related to VSCode compatibility

Comments

@tsmaeder
Copy link
Contributor

tsmaeder commented Sep 1, 2021

Feature Description:

Add InputBoxOptions#title, see https://code.visualstudio.com/api/references/vscode-api#InputBoxOptions

Note that MonacoQuickInputService#input actually just eats the input box option, so in order to implement and test this, we'll have to fix the bug.
@tsmaeder tsmaeder added good first issue good first issues for new contributors vscode issues related to VSCode compatibility labels Sep 1, 2021
@tsmaeder tsmaeder mentioned this issue Sep 1, 2021
Closed
48 tasks
@tsmaeder tsmaeder added the hackathon issues reserved for hackatons label Dec 8, 2021
@tsmaeder tsmaeder assigned tsmaeder and unassigned tsmaeder Dec 8, 2021
@tsmaeder tsmaeder removed the hackathon issues reserved for hackatons label Dec 8, 2021
@tsmaeder
Copy link
Contributor Author

Not sure whether the version of VS Code we have already supports the title field in InputOptions.

@vince-fugnitto
Copy link
Member

I confirmed that the monaco upgrade is required for the changes to work #10736:

image

@vince-fugnitto vince-fugnitto mentioned this issue Mar 24, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue good first issues for new contributors vscode issues related to VSCode compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

plugin: add support for title property in InputBoxOptions eclipse-theia/theia
2 participants
@tsmaeder @vince-fugnitto