From 8814c201fc10b8081fb3d710873e8e0e3c09dc82 Mon Sep 17 00:00:00 2001 From: Sven Efftinge Date: Sat, 26 Oct 2019 16:54:20 +0000 Subject: [PATCH] [monaco] Fix bad preference initialization first register override identifier, because monaco will immediately update already opened documents and then initialize with bad preferences. Fixes #6449 Signed-off-by: Sven Efftinge --- .../src/browser/monaco-frontend-application-contribution.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/monaco/src/browser/monaco-frontend-application-contribution.ts b/packages/monaco/src/browser/monaco-frontend-application-contribution.ts index 5ee145ad1073a..357d925d2f847 100644 --- a/packages/monaco/src/browser/monaco-frontend-application-contribution.ts +++ b/packages/monaco/src/browser/monaco-frontend-application-contribution.ts @@ -35,8 +35,9 @@ export class MonacoFrontendApplicationContribution implements FrontendApplicatio } const registerLanguage = monaco.languages.register.bind(monaco.languages); monaco.languages.register = language => { - registerLanguage(language); + // first register override identifier, because monaco will immediately update already opened documents and then initialize with bad preferences. this.preferenceSchema.registerOverrideIdentifier(language.id); + registerLanguage(language); }; }