Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ask for confirmation before all destructive operations #462

Closed
12 tasks
pcdavid opened this issue Apr 27, 2021 · 3 comments
Closed
12 tasks

Ask for confirmation before all destructive operations #462

pcdavid opened this issue Apr 27, 2021 · 3 comments

Comments

@pcdavid
Copy link
Member

pcdavid commented Apr 27, 2021

Problem

Some operations like deleting a representation or an element (and all its descendants) from the explorer are destructive, but currently they do not ask for confirmation before.
Deleting a whole document does ask for confirmation, but there is no particular reason to treat documents differently from e.g. the root elements inside of them (deleting them is as impacting as deleting the document).

Solution

Make the confirmation dialog available on all concepts of the explorer (objects, representations, etc)

Rabbit holes

No-gos

  • A large set of validation rules for specific DSLs
  • Dynamic contributions of additional validation rules.

Test

  • Automated developer tests merged and pass (with reasonable code coverage)
  • Automated End-to-End tests merged and pass (Cypress)
  • Feature/bug fix manually tested/validated by at least one person not involved in the implementation
  • Collaborative tests passed by hand
  • Exploratory test passed by MEB
  • Business acceptance test passed by MEB

Doc

  • Internal Doc updated
  • External Doc updated
  • Validation Doc updated

UX/UI

  • Zeroheight updated
  • Storybook updated

Next

  • Any left-over tasks added to the issues on Github
@sbegaudeau
Copy link
Member

I'm removing it from the 0.4.0 milestone since it may arrived in this milestone but it's not sure for the moment.

@pcdavid
Copy link
Member Author

pcdavid commented Oct 14, 2021

As part of #692 which generalizes the treatment of explorer items, the DeleteDocumentModal is/will be removed as it was too specific to the document type to match the new generic behavior.

I think now would be the right time to introduce a generic deletion confirmation modal and use it for relevant operations from the explorer:

  • document removal;
  • item removal;
  • representation removal (Slightly less critical, the most you can lose at the moment is a custom layout. Other that than you can always recreate a structurally equivalent representation.)

@pcdavid
Copy link
Member Author

pcdavid commented Feb 9, 2024

See #3089 which covers this.

@pcdavid pcdavid closed this as completed Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants