New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for the edition of the routing points #997

Closed

sbegaudeau opened this issue Jan 21, 2022 · 0 comments · Fixed by #1080

Assignees

Labels

difficulty: medium type: feature request

Milestone

Member

sbegaudeau commented Jan 21, 2022

No description provided.

sbegaudeau added type: feature request difficulty: medium area: backend labels

sbegaudeau added this to the 2022.03.0 milestone

sbegaudeau assigned gcoutable

gcoutable added a commit that referenced this issue


          [997] Add frontend support for edition of edges

cda6a87

Do not handle self-loop edge yet.

Bug: #997
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>

gcoutable added a commit that referenced this issue


          [997] Prevent move event to be sent when handling routing points move

4e6cc63

Bug: #997
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>

gcoutable added a commit that referenced this issue


          [997] Send updated routing points to backend

7d01179

Bug: #997
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>

gcoutable added a commit that referenced this issue


          [997] Prevent the cursor mouse listener to trigger unwanted update model

769b6f0

When the model is updated after a new version of the diagram has been
sent by the backend, the next time the cursor mouse listener is
triggered (at the next mouse move), it updates the model and thus,
forces sprotty to render the diagram again. Sometime it may look like
the diagram is blinking especially when an edge is selected and one of
its routing points has been modified.

Bug: #997
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>

gcoutable added a commit that referenced this issue


          [997] Position edge label regarding the number or routing point

2a4458e

Bug: #997
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>

gcoutable added a commit that referenced this issue


          [997] Do not remove routing points while moving edges

3c899b2

Bug: #997
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>

gcoutable added a commit that referenced this issue


          [997] Add ADR about the support of routing points edition

c47501f

Bug: #997
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>

gcoutable mentioned this issue

Add support for edge routing points edition #1080

Merged

8 tasks

gcoutable added a commit that referenced this issue


          [997] Add frontend support for edition of edges

ef206c2

Do not handle self-loop edge.

Bug: #997
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>

gcoutable added a commit that referenced this issue


          [997] Prevent move event to be sent when handling routing points move

a27be8c

Bug: #997
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>

gcoutable added a commit that referenced this issue


          [997] Send updated routing points to backend

c5a7df6

Bug: #997
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>

gcoutable added a commit that referenced this issue


          [997] Prevent the cursor mouse listener to trigger unwanted update model

7af3a91

When the model is updated after a new version of the diagram has been
sent by the backend, the next time the cursor mouse listener is
triggered (at the next mouse move), it updates the model and thus,
forces sprotty to render the diagram again. Sometime it may look like
the diagram is blinking especially when an edge is selected and one of
its routing points has been modified.

Bug: #997
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>

gcoutable added a commit that referenced this issue


          [997] Position edge label regarding the number or routing point

a90e0a2

Bug: #997
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>

gcoutable added a commit that referenced this issue


          [997] Do not remove routing points while moving edges

d973a61

Bug: #997
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>

gcoutable added a commit that referenced this issue


          [997] Add ADR about the support of routing points edition

c877bdc

Bug: #997
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>

gcoutable added a commit that referenced this issue


          [997] Improve routing handle rendering style

49bb9ec

Bug: #997
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>

gcoutable mentioned this issue

Edges connected to moved elements are reset to a single segment #801

Closed

sbegaudeau modified the milestones: 2022.3.0, 2022.5.0

gcoutable added a commit that referenced this issue


          [997] Add frontend support for edition of edges

c6a92f0

Do not handle self-loop edge.

Bug: #997
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>

gcoutable added a commit that referenced this issue


          [997] Prevent move event to be sent when handling routing points move

ee4caab

Bug: #997
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>

sbegaudeau pushed a commit that referenced this issue


          [997] Keep the edge shape while moving a parent node

b5d5e34

- Frontend:
  - during move, routing points of edges with source and target in
resolvedMove are also moved.
- Backend (incremental layout):
  - Need to compute the delta between previous position and new position
of the moved node
  - Because we can only move one node at a time, apply the delta to
routing points of edges which have source and target contained by the
moved element

Bug: #997
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>

sbegaudeau pushed a commit that referenced this issue


          [997] Move edge label only when necessary

0de3f0e

Bug: #997
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>

sbegaudeau pushed a commit that referenced this issue


          [997] Write tests for the sirius move command

2546aa1

Move eveything related to the sirius drag and drop module in a specific
folder including the resize feature

Bug: #997
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>

sbegaudeau pushed a commit that referenced this issue


          [997] Improve overlap updater

44c7835

Update routing point position of edge "contained" by a node moved by the
overlap updater.

Bug: #997
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>

sbegaudeau pushed a commit that referenced this issue


          [997] Fix small rebase issues

f6db101

Bug: #997
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>

sbegaudeau pushed a commit that referenced this issue


          [997] Fix implicit override

Bug: #997
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>

sbegaudeau pushed a commit that referenced this issue


          [997] Add entry to changelog

01c8771

Bug: #997
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>

sbegaudeau pushed a commit that referenced this issue


          [997] Disable EdgeReconnection since edge edition is enabled

578149e

- Replace the sprotty reconnect command by an empty one. The empty
reconnect command will be removed as soon as we will support the edge
reconnection.
- An edge end can still be moved, but the move will never be taken
account.

Bug: #997
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>

sbegaudeau pushed a commit that referenced this issue


          [997] Disable EdgeReconnection since edge edition is enabled

63b6c43

- Replace the sprotty reconnect command by an empty one. The empty
reconnect command will be removed as soon as we will support the edge
reconnection.
- An edge end can still be moved, but the move will never be taken
account.

Bug: #997
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>

sbegaudeau pushed a commit that referenced this issue


          [997] Add frontend support for edition of edges

6d7ca28

Do not handle self-loop edge.

Bug: #997
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>

sbegaudeau pushed a commit that referenced this issue


          [997] Prevent move event to be sent when handling routing points move

ee9a7a3

Bug: #997
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>

sbegaudeau pushed a commit that referenced this issue


          [997] Send updated routing points to backend

b619827

Bug: #997
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>

sbegaudeau pushed a commit that referenced this issue


          [997] Prevent the cursor mouse listener to trigger unwanted update model

65f3986

When the model is updated after a new version of the diagram has been
sent by the backend, the next time the cursor mouse listener is
triggered (at the next mouse move), it updates the model and thus,
forces sprotty to render the diagram again. Sometime it may look like
the diagram is blinking especially when an edge is selected and one of
its routing points has been modified.

Bug: #997
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>

sbegaudeau pushed a commit that referenced this issue


          [997] Position edge label regarding the number or routing point

20e986e

Bug: #997
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>

sbegaudeau pushed a commit that referenced this issue


          [997] Do not remove routing points while moving edges

60757d0

Bug: #997
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>

sbegaudeau pushed a commit that referenced this issue


          [997] Add ADR about the support of routing points edition

66fc816

Bug: #997
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>

sbegaudeau pushed a commit that referenced this issue


          [997] Improve routing handle rendering style

46962e2

Bug: #997
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>

sbegaudeau pushed a commit that referenced this issue


          [997] Prevent to display the palette on SRoutingHandle click

c88b433

Bug: #997
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>

sbegaudeau pushed a commit that referenced this issue


          [997] Keep the edge shape while moving a parent node

b315b93

- Frontend:
  - during move, routing points of edges with source and target in
resolvedMove are also moved.
- Backend (incremental layout):
  - Need to compute the delta between previous position and new position
of the moved node
  - Because we can only move one node at a time, apply the delta to
routing points of edges which have source and target contained by the
moved element

Bug: #997
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>

sbegaudeau pushed a commit that referenced this issue


          [997] Move edge label only when necessary

b60dcac

Bug: #997
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>

sbegaudeau pushed a commit that referenced this issue


          [997] Write tests for the sirius move command

6e71b98

Move eveything related to the sirius drag and drop module in a specific
folder including the resize feature

Bug: #997
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>

sbegaudeau pushed a commit that referenced this issue


          [997] Improve overlap updater

098ed97

Update routing point position of edge "contained" by a node moved by the
overlap updater.

Bug: #997
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>

sbegaudeau pushed a commit that referenced this issue


          [997] Fix small rebase issues

ae2e532

Bug: #997
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>

sbegaudeau pushed a commit that referenced this issue


          [997] Fix implicit override

96792cb

Bug: #997
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>

sbegaudeau pushed a commit that referenced this issue


          [997] Add entry to changelog

6da5f62

Bug: #997
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>

sbegaudeau pushed a commit that referenced this issue


          [997] Disable EdgeReconnection since edge edition is enabled

7b9515a

- Replace the sprotty reconnect command by an empty one. The empty
reconnect command will be removed as soon as we will support the edge
reconnection.
- An edge end can still be moved, but the move will never be taken
account.

Bug: #997
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>

sbegaudeau pushed a commit that referenced this issue


          [997] Add support for the edition of the routing points

5ad28c8

Bug: #997
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>

sbegaudeau pushed a commit that referenced this issue


          [997] Add support for the edition of the routing points

02fcc5f

Bug: #997
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>

sbegaudeau pushed a commit that referenced this issue


          [997] Add support for the edition of the routing points

d90a9a0

Bug: #997
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>

sbegaudeau closed this as completed in #1080

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment