-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibility layer: handle DotDescription style for Bordered Nodes #897
Comments
Bug: eclipse-sirius#897 Change-Id: Id41b42e980bd80b67778a9195dd51013636edc1d Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
Bug: eclipse-sirius#897 Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
Bug: #897 Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
I don't understand how we can says that this implements the |
A SVG rectangle with a 100 radius is a circle. No change require on the frontend this way. |
But the border radius is an absolute dimension, not a percentage. It will only render as a Sirius Desktop "Dot" at small sizes: Yes, in SVG the I guess we could embrace the fact that we will render as SVGs, make |
You're right, I believed that we were interpreting it as a percentage on the frontend. We could indeed make |
👍 to "embrace SVG and CSS" (and not try to hide/abstract their more powerful features) |
Expected behavior
Handle Dot style for Bordered Nodes in the compatibility layer.
A Dot is simply a RectangularNodeStyle with a radius = 100.
Describe alternatives you've considered
A new CircleNodeStyle could be implemented instead of using RectangularNodeStyle with a radius = 100
The text was updated successfully, but these errors were encountered: