Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add delete from diagram generic tool in diagrams #822

Closed
1 task done
AxelRICHARD opened this issue Nov 8, 2021 · 0 comments · Fixed by #960
Closed
1 task done

Add delete from diagram generic tool in diagrams #822

AxelRICHARD opened this issue Nov 8, 2021 · 0 comments · Fixed by #960
Assignees
@sbegaudeau @AxelRICHARD
Labels
type: feature request
Milestone
2022.01.0

Comments

@AxelRICHARD
Copy link
Contributor

  • I have checked that this feature has not yet been suggested by someone else.

Expected behavior

Today, all diagram elements have a delete tool. This tool delete the element from the diagram and also from the model.
For a specific mapping, if a delete element tool has been defined in the odesign, then the behavior of the delete element tool is called instead of the generic delete.

The goal is to have two generic delete tools: one for the graphical deletion (only on unsynchronized mappings) and one for the model deletion.
If a delete element tool has been defined in the odesign for a mapping, then the generic delete tools are not available anymore. Only the specific delete element tool is available.
AxelRICHARD added a commit to AxelRICHARD/sirius-components that referenced this issue Nov 17, 2021
@AxelRICHARD
[822] Add delete from diagram generic tool in diagrams
f186960 
Bug: eclipse-sirius#822
Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
@AxelRICHARD AxelRICHARD mentioned this issue Nov 17, 2021
Closed
1 task
@pcdavid pcdavid added this to the 2021.12.0 milestone Nov 18, 2021
@sbegaudeau sbegaudeau modified the milestones: 2021.12.0, 2022.02.0 Dec 2, 2021
@sbegaudeau sbegaudeau linked a pull request Dec 2, 2021 that will close this issue
[822] Add delete from diagram generic tool in diagrams #836
Closed
1 task
sbegaudeau added a commit that referenced this issue Jan 13, 2022
@sbegaudeau
[822] Add the DiagramDescription in the context of the DiagramWebSock…
469e984 
…etContainer

It will allow us to compute additional information such as the list of all
the unsynchronized nodes and edges in order to perform some operations

Bug: #822
Signed-off-by: Stéphane Bégaudeau <stephane.begaudeau@obeo.fr>
sbegaudeau added a commit that referenced this issue Jan 14, 2022
@sbegaudeau
[822] Add a DeleteFromDiagram tool in the contextual palette
2b2a302 
Bug: #822
Signed-off-by: Stéphane Bégaudeau <stephane.begaudeau@obeo.fr>
sbegaudeau added a commit that referenced this issue Jan 14, 2022
@sbegaudeau
[822] Add a DeleteFromDiagram tool in the contextual palette
2b298bd 
Bug: #822
Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
Signed-off-by: Stéphane Bégaudeau <stephane.begaudeau@obeo.fr>
sbegaudeau added a commit that referenced this issue Jan 14, 2022
@sbegaudeau
[822] Add the support for the GRAPHICAL deletion policy in the compat…
7a6b9cc 
…ibility layer

Bug: #822
Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
Signed-off-by: Stéphane Bégaudeau <stephane.begaudeau@obeo.fr>
sbegaudeau added a commit that referenced this issue Jan 14, 2022
@sbegaudeau
[822] Add the support for the GRAPHICAL deletion policy in the compat…
5057fdf 
…ibility layer

Bug: #822
Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
Signed-off-by: Stéphane Bégaudeau <stephane.begaudeau@obeo.fr>
@sbegaudeau sbegaudeau linked a pull request Jan 14, 2022 that will close this issue
[822] Add support for graphical deletion #960
Merged
sbegaudeau added a commit that referenced this issue Jan 14, 2022
@sbegaudeau
[822] Add the DiagramDescription in the context of the DiagramWebSock…
e3a37e8 
…etContainer

It will allow us to compute additional information such as the list of all
the unsynchronized nodes and edges in order to perform some operations

Bug: #822
Signed-off-by: Stéphane Bégaudeau <stephane.begaudeau@obeo.fr>
sbegaudeau added a commit that referenced this issue Jan 14, 2022
@sbegaudeau
[822] Add a DeleteFromDiagram tool in the contextual palette
1e2b897 
Bug: #822
Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
Signed-off-by: Stéphane Bégaudeau <stephane.begaudeau@obeo.fr>
sbegaudeau added a commit that referenced this issue Jan 14, 2022
@sbegaudeau
[822] Add the support for the GRAPHICAL deletion policy in the compat…
0c602da 
…ibility layer

Bug: #822
Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
Signed-off-by: Stéphane Bégaudeau <stephane.begaudeau@obeo.fr>
sbegaudeau added a commit that referenced this issue Jan 14, 2022
@sbegaudeau
[822] Add the DiagramDescription in the context of the DiagramWebSock…
d06e77a 
…etContainer

It will allow us to compute additional information such as the list of all
the unsynchronized nodes and edges in order to perform some operations

Bug: #822
Signed-off-by: Stéphane Bégaudeau <stephane.begaudeau@obeo.fr>
sbegaudeau added a commit that referenced this issue Jan 14, 2022
@sbegaudeau
[822] Add a DeleteFromDiagram tool in the contextual palette
2607bb0 
Bug: #822
Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
Signed-off-by: Stéphane Bégaudeau <stephane.begaudeau@obeo.fr>
sbegaudeau added a commit that referenced this issue Jan 14, 2022
@sbegaudeau
[822] Add the support for the GRAPHICAL deletion policy in the compat…
c19a9bb 
…ibility layer

Bug: #822
Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
Signed-off-by: Stéphane Bégaudeau <stephane.begaudeau@obeo.fr>
pcdavid added a commit that referenced this issue Jan 17, 2022
@pcdavid
[822] Handle 'Delete from Diagram' on studios
703dee7 
The default delete behavior on studios must be made aware of the two
distinct DeletionPolicies we support now.

Also add the "selectedEdge" variable to the context when invoking a
deletion on an edge, similar to "selectedNode" for nodes deletion.

Bug: #822
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
@pcdavid pcdavid mentioned this issue Jan 17, 2022
Merged
17 tasks
sbegaudeau added a commit that referenced this issue Jan 17, 2022
@sbegaudeau
[822] Fix a crash while clicking on an edge
542b9c1 
Bug: #822
Signed-off-by: Stéphane Bégaudeau <stephane.begaudeau@obeo.fr>
@sbegaudeau sbegaudeau mentioned this issue Jan 17, 2022
Merged
pcdavid pushed a commit that referenced this issue Jan 17, 2022
@sbegaudeau @pcdavid
[822] Fix a crash while clicking on an edge
6513643 
Bug: #822
Signed-off-by: Stéphane Bégaudeau <stephane.begaudeau@obeo.fr>
sbegaudeau pushed a commit that referenced this issue Jan 18, 2022
@pcdavid @sbegaudeau
[822] Handle 'Delete from Diagram' on studios
2f6c2ea 
The default delete behavior on studios must be made aware of the two
distinct DeletionPolicies we support now.

Also add the "selectedEdge" variable to the context when invoking a
deletion on an edge, similar to "selectedNode" for nodes deletion.

Bug: #822
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
sbegaudeau pushed a commit that referenced this issue Jan 18, 2022
@pcdavid @sbegaudeau
[822] Handle 'Delete from Diagram' on studios
cb93d10 
The default delete behavior on studios must be made aware of the two
distinct DeletionPolicies we support now.

Also add the "selectedEdge" variable to the context when invoking a
deletion on an edge, similar to "selectedNode" for nodes deletion.

Bug: #822
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbegaudeau sbegaudeau

@AxelRICHARD AxelRICHARD

Labels
type: feature request
Projects
None yet
Milestone
2022.01.0
3 participants
@pcdavid @sbegaudeau @AxelRICHARD