Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move representations out of the explorer and into a dedicated view #694

Closed
12 tasks
sbegaudeau opened this issue Aug 16, 2021 · 1 comment · Fixed by #709
Closed
12 tasks

Move representations out of the explorer and into a dedicated view #694

sbegaudeau opened this issue Aug 16, 2021 · 1 comment · Fixed by #709
Assignees
@gcoutable
Labels
difficulty: medium type: feature request
Milestone
2021.12.0

Comments

@sbegaudeau
Copy link
Member

Problem

Representations are hard to find in the explorer, we want to make them more visible.

Solution

Representations will be removed from the explorer and moved to a new dedicated view, contextual to the selection, on the right side of the workbench.

Cutting backs

Rabbit holes

No-gos

Test

  • Automated developer tests merged and pass (with reasonable code coverage)
  • Automated End-to-End tests merged and pass (Cypress)
  • Feature/bug fix manually tested/validated by at least one person not involved in the implementation
  • Collaborative tests passed by hand
  • Exploratory test passed by MEB
  • Business acceptance test passed by MEB

Doc

  • Internal Doc updated
  • External Doc updated
  • Validation Doc updated

UX/UI

  • Zeroheight updated
  • Storybook updated

Next

  • Any left-over tasks in the Github issues
@sbegaudeau sbegaudeau added this to the 0.5.0 milestone Aug 16, 2021
@sbegaudeau
Copy link
Member Author

See the relevant ADR for additional information: https://github.com/eclipse-sirius/sirius-components/blob/master/doc/adrs/028_move_representations_out_of_the_explorer.adoc

gcoutable added a commit that referenced this issue Aug 20, 2021
@gcoutable
[694] WIP: Provide a representation to display representations
7722a33 
The new representation is can display all existing representation for
the current selection.

Bug: #694
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
@gcoutable gcoutable mentioned this issue Aug 20, 2021
Merged
17 tasks
gcoutable added a commit that referenced this issue Sep 16, 2021
@gcoutable
[694] Provide a representation to display representations
c454ebd 
Projects that depends on sirius-components can provide:
- A Spring service that implements IRepresentationsDescriptionProvider
- A Subscription data fetcher to subscribe to the "representationsEvent"

Providing these components will make possible the display of a
representation that display sirius representations for the current
selection.

Bug: #694
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
gcoutable added a commit that referenced this issue Sep 16, 2021
@gcoutable
[694] Provide a kind to ListItem
5bcf871 
It makes possible to set the selection from the ListPropertySection

Bug: #694
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
gcoutable added a commit that referenced this issue Sep 16, 2021
@gcoutable
[694] Add ListItem#Deletable support in the backend
8bcba68 
Bug: #694
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
gcoutable added a commit that referenced this issue Sep 16, 2021
@gcoutable
[694] Add support for deletable in the frontend
591e89d 
Bug: #694
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
gcoutable added a commit that referenced this issue Sep 16, 2021
@gcoutable
[694] Use immutable widget items
cacc627 
Bug: #694
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
gcoutable added a commit that referenced this issue Sep 16, 2021
@gcoutable
[694] Prevent the "None" list item to be selected
2a41cb3 
Bug: #694
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
gcoutable added a commit that referenced this issue Sep 16, 2021
@gcoutable
[694] Add a delete icon on each list item
c15b710 
The delete icon is disabled when the list item cannot be deleted.

Bug: #694
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
gcoutable added a commit that referenced this issue Sep 16, 2021
@gcoutable
[694] Add the support for DeleteListItem in frontend
fba1e77 
Bug: #694
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
gcoutable added a commit that referenced this issue Sep 16, 2021
@gcoutable
[694] WIP Add the support for the DeleteListItemEventHandler
4c93ee7 
Wait for some refactoring that will make possible to communicate with
the EditingContextEventProcessor and DataFetcher and some refactoring
that will make possible to give more information about what the
EventHandler did (More than just a Status with OK/ERROR).

Bug: #694
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
gcoutable added a commit that referenced this issue Sep 24, 2021
@gcoutable
[694] Provide a representation to display representations
c9a3fcc 
Projects that depends on sirius-components can provide:
- A Spring service that implements IRepresentationsDescriptionProvider
- A Subscription data fetcher to subscribe to the "representationsEvent"

Providing these components will make possible the display of a
representation that display sirius representations for the current
selection.

Bug: #694
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
gcoutable added a commit that referenced this issue Sep 24, 2021
@gcoutable
[694] Provide a kind to ListItem
14da5ee 
It makes possible to set the selection from the ListPropertySection

Bug: #694
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
gcoutable added a commit that referenced this issue Sep 24, 2021
@gcoutable
[694] Add ListItem#Deletable support in the backend
ae64b89 
Bug: #694
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
gcoutable added a commit that referenced this issue Sep 24, 2021
@gcoutable
[694] Add support for deletable in the frontend
4968e97 
Bug: #694
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
gcoutable added a commit that referenced this issue Sep 24, 2021
@gcoutable
[694] Use immutable widget items
f1d03c9 
Bug: #694
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
gcoutable added a commit that referenced this issue Sep 24, 2021
@gcoutable
[694] Prevent the "None" list item to be selected
2e23cac 
Bug: #694
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
gcoutable added a commit that referenced this issue Sep 24, 2021
@gcoutable
[694] Add a delete icon on each list item
b7b334e 
The delete icon is disabled when the list item cannot be deleted.

Bug: #694
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
gcoutable added a commit that referenced this issue Sep 24, 2021
@gcoutable
[694] Add the support for DeleteListItem in frontend
575bb74 
Bug: #694
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
gcoutable added a commit that referenced this issue Sep 24, 2021
@gcoutable
[694] Add the support for the DeleteListItemEventHandler
2fd0961 
Bug: #694
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
gcoutable added a commit that referenced this issue Sep 24, 2021
@gcoutable
[694] Make possible to contribute data to the success status
d3951f4 
Bug: #694
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
gcoutable added a commit that referenced this issue Sep 24, 2021
@gcoutable
[694] Make possible to contribute data to the change description
5f61481 
The contributed data meant to be handled by the editing context event
processor when it is notified thanks to its change description sink

Bug: #694
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
gcoutable added a commit that referenced this issue Nov 9, 2021
@gcoutable
[694] Add a representation refresh policy registry
b021926 
Bug: #694
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
gcoutable added a commit that referenced this issue Nov 9, 2021
@gcoutable
[694] Add the support for representation refresh policy in forms
9039c13 
Bug: #694
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
gcoutable added a commit that referenced this issue Nov 9, 2021
@gcoutable
[694] Add the support for representation refresh policy in selection
a524532 
Bug: #694
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
gcoutable added a commit that referenced this issue Nov 9, 2021
@gcoutable
[694] Add the support for representation refresh policy in tree
b4fab18 
Bug: #694
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
gcoutable added a commit that referenced this issue Nov 9, 2021
@gcoutable
[694] Add the support for representation refresh policy in validation
c639823 
Bug: #694
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
gcoutable added a commit that referenced this issue Nov 9, 2021
@gcoutable
[694] Add the support for representation refresh policy in diagram
59e3def 
Bug: #694
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
gcoutable added a commit that referenced this issue Nov 9, 2021
@gcoutable
[694] Add delete list item event handler unit test
8f0541c 
Bug: #694
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
gcoutable added a commit that referenced this issue Nov 9, 2021
@gcoutable
[694] Fix architectural issues
bf64fbc 
Bug: #694
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
gcoutable added a commit that referenced this issue Nov 9, 2021
@gcoutable
[694] Fix an issue with the link
9fe1d4d 
Everything worked well with Chrome, but with Firefox a <a> component
with an href equals to '#' triggered a page reload.
So instead of a material ui <Link>, a customized <Typography> is used.

Bug: #694
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
gcoutable added a commit that referenced this issue Nov 9, 2021
@gcoutable
[694] Can customize the ability to "select" a list item
b087592 
The list property section should not make assumption about the ability
of a list item to be a selection.

Bug: #694
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
gcoutable added a commit that referenced this issue Nov 9, 2021
@gcoutable
[694] Fix rebase compilation error
c56f52a 
Bug: #694
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
gcoutable added a commit that referenced this issue Nov 9, 2021
@gcoutable
[694] Fix style
468b3b9 
- Makes the list widget takes all available space.
- Removes the carriage return between the icon and the text in the list
item.

Bug: #694
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
gcoutable added a commit that referenced this issue Nov 9, 2021
@gcoutable
[694] Add datatest-id for integration test
0b6660a 
Bug: #694
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
gcoutable added a commit that referenced this issue Nov 9, 2021
@gcoutable
[694] One right view expended at a time
6679aaa 
Bug: #694
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
gcoutable added a commit that referenced this issue Nov 9, 2021
@gcoutable
[694] Prevent accordion height to be higher than the application height
8070199 
The collapse component of material-ui hard set the height of its content
at the expand animation start. When the content of the accordion height
exceeds the page height a scroll bar is display on the whole page, for a
few milliseconds.
To prevent that scroll bar to be displayed, the Collapse component is
customized to force the accordion height to stay in line.

Bug: #694
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
gcoutable added a commit that referenced this issue Nov 9, 2021
@gcoutable
[694] Disable accordion collapse/expand internal transition
9ab734e 
First point, the collapse component relies on react transition component
which has a timeout used to define the duration of the transition.
Second point, customizing Collapse onEntering and onExit to force the
height of the accordion content to 'auto', lets the browser calculating
the accordion height, which makes the global page overflow when the
accordion content is too high. In conjunction of an "overflow: auto"
(which we have done), only the accordion content is overflowing (which
is what we want). Doing this has a price, transition cannot be made
from/to "height: auto", and thus, the transition between the opening or
the closing instantaneous. But because of the first point, internally
the animation duration is still present.

Knowing those two points, a small delay can bee seen when an accordion
with a high content is expanded. This commit removes that delay.

Bug: #694
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
gcoutable added a commit that referenced this issue Nov 9, 2021
@gcoutable
[694] Makes the expand icon smaller
bf47f7e 
With the default expand icon size, when an accordion is
expanded/collapsed, the icon size seems to exceed the size of its parent
during its rotate animation. Using a smaller expand icon resolve this
issue.

Bug: #694
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
gcoutable added a commit that referenced this issue Nov 9, 2021
@gcoutable
[694] Do not use pattern builder to create a Success
64e4018 
Bug: #694
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
gcoutable added a commit that referenced this issue Nov 9, 2021
@gcoutable
[694] Diagram shouldRefresh should be in diagram event processor
78f719c 
To verify is a diagram should refresh or not is not a
DiagramCreationService responsibility. It is the diagram event processor
that has to verify this statement.

Bug: #694
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
gcoutable added a commit that referenced this issue Nov 9, 2021
@gcoutable
[694] A representationsDescriptionProvider always return a description
82a9942 
Bug: #694
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
gcoutable added a commit that referenced this issue Nov 9, 2021
@gcoutable
[694] Fix various things
7c8d4d3 
Bug: #694
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
gcoutable added a commit that referenced this issue Nov 9, 2021
@gcoutable
[694] Ease change description creation from success
5d63826 
Bug: #694
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
gcoutable added a commit that referenced this issue Nov 9, 2021
@gcoutable
[694] Contribute to CHANGELOG
20e7aae 
Bug: #694
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
sbegaudeau pushed a commit that referenced this issue Nov 10, 2021
@gcoutable @sbegaudeau
[694] Provide a representation to display representations
72b9f87 
Projects that depends on Sirius Components should now provide:

- a Spring service that implements IRepresentationsDescriptionProvider
- a Subscription data fetcher to subscribe to the "representationsEvent"

Providing these components will make possible the display of a
representation that display representations for the current selection.

This contribution comes with significant changes to the behavior of the
left and right sides in order to prevent layout issues during the expand
and collapse. It also provides some improvements to the Success object
in order to provide additional information. Those pieces of information
will be used to compute the ChangeDescription. It is a first step to help
users create representations which do not display only semantic elements.

Bug: #694
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
sbegaudeau pushed a commit that referenced this issue Nov 10, 2021
@gcoutable @sbegaudeau
[694] Provide a representation to display representations
2c8ee26 
Projects that depends on Sirius Components should now provide:

- a Spring service that implements IRepresentationsDescriptionProvider
- a Subscription data fetcher to subscribe to the "representationsEvent"

Providing these components will make possible the display of a
representation that display representations for the current selection.

This contribution comes with significant changes to the behavior of the
left and right sides in order to prevent layout issues during the expand
and collapse. It also provides some improvements to the Success object
in order to provide additional information. Those pieces of information
will be used to compute the ChangeDescription. It is a first step to help
users create representations which do not display only semantic elements.

Bug: #694
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
sbegaudeau pushed a commit that referenced this issue Nov 10, 2021
@gcoutable @sbegaudeau
[694] Provide a representation to display representations
1680b65 
Projects that depends on Sirius Components should now provide:

- a Spring service that implements IRepresentationsDescriptionProvider
- a Subscription data fetcher to subscribe to the "representationsEvent"

Providing these components will make possible the display of a
representation that display representations for the current selection.

This contribution comes with significant changes to the behavior of the
left and right sides in order to prevent layout issues during the expand
and collapse. It also provides some improvements to the Success object
in order to provide additional information. Those pieces of information
will be used to compute the ChangeDescription. It is a first step to help
users create representations which do not display only semantic elements.

Bug: #694
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
sbegaudeau pushed a commit that referenced this issue Nov 10, 2021
@gcoutable @sbegaudeau
[694] Provide a representation to display representations
8da4016 
Projects that depends on Sirius Components should now provide:

- a Spring service that implements IRepresentationsDescriptionProvider
- a Subscription data fetcher to subscribe to the "representationsEvent"

Providing these components will make possible the display of a
representation that display representations for the current selection.

This contribution comes with significant changes to the behavior of the
left and right sides in order to prevent layout issues during the expand
and collapse. It also provides some improvements to the Success object
in order to provide additional information. Those pieces of information
will be used to compute the ChangeDescription. It is a first step to help
users create representations which do not display only semantic elements.

Bug: #694
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
Gelio pushed a commit to Gelio/CAL-web that referenced this issue Nov 10, 2021
@gcoutable @Gelio
Add the support for the representation representations
cb77e63 
Provides an implementation of IRepresentationDescriptionProvider and a
subscription data fetcher that subscribe to the "representationsEvent"
in order to display the representations of the current selection

Bug: eclipse-sirius/sirius-web#694
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gcoutable gcoutable

Labels
difficulty: medium type: feature request
Projects
None yet
Milestone
2021.12.0
Development

Successfully merging a pull request may close this issue.

[694] Provide a representation to display representations eclipse-sirius/sirius-web
2 participants
@sbegaudeau @gcoutable