Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The default value for the edge description color makes it barely visible #646

Closed
4 tasks done
gcoutable opened this issue Jul 22, 2021 · 2 comments · Fixed by #650
Closed
4 tasks done

The default value for the edge description color makes it barely visible #646

gcoutable opened this issue Jul 22, 2021 · 2 comments · Fixed by #650

Comments

@gcoutable
Copy link
Member

  • I have checked that this bug has not yet been reported by someone else
  • I have checked that this bug appears on Chrome
  • I have specified the version :
  • latest
  • I have specified my environment :
  • my computer: Windows
  • Cloud

Screenshots

image

Steps to reproduce

  1. In a "Studio" project:
  2. Define a view on a domain
  3. Define an Edge description. Keep default color value
  4. In an "Instance" project:
  5. Create a diagram and create an edge based on the Edge description

Expected behavior

The edge should be visible with a human eye.

Actual behavior

The edge is barely visible.

@gcoutable gcoutable added this to the 0.4.0 milestone Jul 22, 2021
@pcdavid pcdavid self-assigned this Jul 23, 2021
@pcdavid
Copy link
Member

pcdavid commented Jul 23, 2021

I don't reproduce. For me, both on staging and locally, a newly created EdgeDescription has a style with color #002639:

2021-07-23_11-04_1

Which looks like this:

2021-07-23_11-04

There is however an issue with the default value for the 'Target Arrow Style', which should be Input Arrow (as on the screenshot above) insted of Output Arrow as it is now. I'll prepare a fix for that.

@pcdavid
Copy link
Member

pcdavid commented Jul 23, 2021

Ah, I see. The bug is indeed present, but for the default value on conditional edge styles.

pcdavid added a commit that referenced this issue Jul 23, 2021
Fixes #646.

Bug: #646
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
@sbegaudeau sbegaudeau removed this from the 0.4.0 milestone Jul 26, 2021
sbegaudeau pushed a commit that referenced this issue Aug 6, 2021
Bug: #646
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
sbegaudeau pushed a commit that referenced this issue Aug 6, 2021
Bug: #646
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants