Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for external java actions #613

Closed
1 task done
Camork opened this issue Jul 5, 2021 · 4 comments · Fixed by #612
Closed
1 task done

Add support for external java actions #613

Camork opened this issue Jul 5, 2021 · 4 comments · Fixed by #612
Labels
difficulty: medium type: feature request
Milestone
2021.12.0

Comments

@Camork
Copy link
Contributor

Camork commented Jul 5, 2021

Reference to the document, we need to support this feature in sirius web.

  • I have checked that this feature has not yet been suggested by someone else.

Expected behavior

The external java action declaration in OD file should work.

Cuttings backs

...

Potential side effects

no

Describe alternatives you've considered

no
@Gelio
Copy link

Gelio commented Nov 3, 2021 •
edited
Loading

I could also benefit from this feature, because I need to modify the model programmatically. At the moment the workaround that I do is that I modified the Java code in sirius-web that loads the documents. It feels like a hack, though.

I see that https://github.com/Camork/sirius-components/commit/ad5b55e4125796f758f2bc469a68ad22f245f7f4 is an implementation of the support for external java actions. I did not test it myself.

How difficult would it be to pull that into this repository? I see #612 is the PR to add it to this repo, but it seems to be stale for 4 months :/

@sbegaudeau
Copy link
Member

We should probably take over this PR by ourselves since the comments I made on the PR have not all been taken into account.

@Camork
Copy link
Contributor Author

Camork commented Nov 4, 2021

We should probably take over this PR by ourselves since the comments I made on the PR have not all been taken into account.

I will rebase this pr and make the adjustment according to the left suggestions.

@sbegaudeau sbegaudeau added this to the 2021.12.0 milestone Nov 10, 2021
sbegaudeau pushed a commit that referenced this issue Nov 10, 2021
@Camork @sbegaudeau
[613] Add support for external java actions
f7e0055 
Bug: #613
Signed-off-by: Charles Wu <camork1@gmail.com>
Signed-off-by: Stéphane Bégaudeau <stephane.begaudeau@obeo.fr>
@sbegaudeau sbegaudeau linked a pull request Nov 10, 2021 that will close this issue
Add support for external java actions #612
Merged
17 tasks
@sbegaudeau
Copy link
Member

Merged in master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty: medium type: feature request
Projects
None yet
Milestone
2021.12.0
Development

Successfully merging a pull request may close this issue.

Add support for external java actions
3 participants
@sbegaudeau @Gelio @Camork