Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The self variable is not available to VSM-based edge creation tools #437

Closed
pcdavid opened this issue Apr 13, 2021 · 0 comments · Fixed by #438
Closed

The self variable is not available to VSM-based edge creation tools #437

pcdavid opened this issue Apr 13, 2021 · 0 comments · Fixed by #438
Assignees
@pcdavid
Labels
difficulty: starter type: bug
Milestone
0.3.0

Comments

@pcdavid
Copy link
Member

pcdavid commented Apr 13, 2021

In Sirius Desktop, edge creation tools defined inside a VSM can expect to get the self variable available, pointing to the semantic element at the source of the edge. See https://github.com/pcdavid/org.eclipse.sirius/blob/master/plugins/org.eclipse.sirius.diagram/src-core/org/eclipse/sirius/diagram/tools/internal/command/builders/EdgeCreationCommandBuilder.java#L203

In Sirius Web, we only have two (more explicit) variables, semanticEdgeSource and semanticEdgeTarget, but we already provide compatibility aliases for source and target (Sirius Desktop names) for these.

For these tools se should also expose self as another alias to semanticEdgeSource.
@pcdavid pcdavid self-assigned this Apr 13, 2021
@pcdavid pcdavid added this to the 0.3.0 milestone Apr 13, 2021
pcdavid added a commit that referenced this issue Apr 13, 2021
@pcdavid
[437] Expose "self" variable to VSM-based edge creation tools
44572a5 
Bug: #437
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
@pcdavid pcdavid mentioned this issue Apr 13, 2021
Merged
pcdavid added a commit that referenced this issue Apr 13, 2021
@pcdavid
[437] Expose "self" variable to VSM-based edge creation tools
6686357 
Fixes #437.

Bug: #437
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
@pcdavid pcdavid linked a pull request Apr 13, 2021 that will close this issue
[437] Expose "self" variable to VSM-based edge creation tools #438
Merged
sbegaudeau pushed a commit that referenced this issue Apr 14, 2021
@pcdavid @sbegaudeau
[437] Expose "self" variable to VSM-based edge creation tools
545a973 
Fixes #437.

Bug: #437
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pcdavid pcdavid

Labels
difficulty: starter type: bug
Projects
None yet
Milestone
0.3.0
Development

Successfully merging a pull request may close this issue.

[437] Expose "self" variable to VSM-based edge creation tools eclipse-sirius/sirius-web
1 participant
@pcdavid