Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Size Computation Expression for edges #407

Closed
1 task done
mt-empty opened this issue Mar 24, 2021 · 3 comments · Fixed by #409
Closed
1 task done

Add support for Size Computation Expression for edges #407

mt-empty opened this issue Mar 24, 2021 · 3 comments · Fixed by #409

Comments

@mt-empty
Copy link

  • I have checked that this feature has not yet been suggested by someone else.

Expected behavior

Size Computation Expression is currently ignored and every edge has a size of 1.
image

Cuttings backs

...

Potential side effects

...

Describe alternatives you've considered

Editing the CSS.

@pcdavid pcdavid self-assigned this Mar 24, 2021
pcdavid added a commit that referenced this issue Mar 24, 2021
Also adjust some APIs to reduce the number of unneeded calls to
VariablesManager.getVariables() which is not free when repeated in hot
loops like during a render.

Fixes #407.

Bug: #407
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
@pcdavid
Copy link
Member

pcdavid commented Mar 24, 2021

PR #409 seems to work, but still needs some automated tests before it can be merged.

With a simple sizeComputationExpression="aql:self.name.size()" on a reference-based edge I get:

2021-03-24_17-06

@mt-empty
Copy link
Author

Just to be clear, I was referring to Sirius web edges. stroke-width doesn't map sizeComputationExpression
image

@pcdavid
Copy link
Member

pcdavid commented Mar 25, 2021

I undestand, the screenshot in my previous comment is from a Sirius Web modeler. Here the stroke-width is 6 because that is the length of "Engine", i.e. the result of aql:self.name.size().

2021-03-25_13-48

@sbegaudeau sbegaudeau linked a pull request Apr 12, 2021 that will close this issue
2 tasks
sbegaudeau pushed a commit that referenced this issue Apr 12, 2021
Also adjust some APIs to reduce the number of unneeded calls to
VariablesManager.getVariables() which is not free when repeated in hot
loops like during a render.

Fixes #407.

Bug: #407
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
@sbegaudeau sbegaudeau added this to the 0.3.0 milestone Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants