Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only the first defined reconnection tool is executed no matter how any of them are defined in a view model #1485

Closed
gcoutable opened this issue Nov 24, 2022 · 2 comments · Fixed by #1497

Comments

@gcoutable
Copy link
Member

Steps to reproduce

  1. Import the following project in sirius-web reconnection-issue.zip
  2. Create a New Representation root diagram on instance/Root element
  3. You should see two edges, they are defined as followed:
    a. Reconnecting increase from t0 to t1 should increase the Entity counter by 1
    b. Reconnecting decrease from t0 to t1 should decrease the Entity counter by 1
  4. Reconnect increase from t0 to t1 then reconnect decrease from t0 to t1

Expected behavior

The Entity counter should be equal to 0

Actual behavior

The Entity counter is equal to -2 or 2, it will depend on which one of the reconnection tools has been converted from View DSL.

@gcoutable
Copy link
Member Author

gcoutable commented Nov 24, 2022

When reconnection tools are converted from View DSL, they are all stored in the diagram description API. Once inside the diagram description, we are not able to choose between two different reconnection tools and thus, we execute the first one encountered.

@gcoutable
Copy link
Member Author

We should try to execute the reconnection tool directly from the View DSL, instead of converting reconnection tools to store them in the diagram description API, as we did for #1457.

@gcoutable gcoutable added this to the 2023.1.0 milestone Nov 24, 2022
@sbegaudeau sbegaudeau self-assigned this Nov 25, 2022
sbegaudeau added a commit that referenced this issue Nov 30, 2022
Bug: #1485
Signed-off-by: Stéphane Bégaudeau <stephane.begaudeau@obeo.fr>
@sbegaudeau sbegaudeau linked a pull request Nov 30, 2022 that will close this issue
39 tasks
sbegaudeau added a commit that referenced this issue Dec 1, 2022
Bug: #1485
Signed-off-by: Stéphane Bégaudeau <stephane.begaudeau@obeo.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants