Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use literal instead of name for Enum label & newValue in EEnumIfDescriptionProvider #1268

Closed
4 tasks done
AxelRICHARD opened this issue Jun 14, 2022 · 0 comments · Fixed by #1249
Closed
4 tasks done

Use literal instead of name for Enum label & newValue in EEnumIfDescriptionProvider #1268

AxelRICHARD opened this issue Jun 14, 2022 · 0 comments · Fixed by #1249
Assignees
@AxelRICHARD
Labels
difficulty: medium type: bug
Milestone
2022.7.0

Comments

@AxelRICHARD
Copy link
Contributor

  • I have checked that this bug has not yet been reported by someone else
  • I have checked that this bug appears on Chrome
  • I have specified the version :
  • latest
  • other: please specify
  • I have specified my environment :
  • All
  • my computer: MacOs
  • Cloud

Screenshots

...

Steps to reproduce

When an Enum has a literal not equals to its name, then in the PropertySections the name is used by default for the label and for the new value.
It causes two problems:

  • The label displays the name (the literal is meant for that as it allows values with special characters)
  • When trying to apply a new value, it causes an error.

By using literal instead of name in both label provider and new value handler, there are no more problems.

Expected behavior

...

Actual behavior

...
@AxelRICHARD AxelRICHARD self-assigned this Jun 14, 2022
@AxelRICHARD AxelRICHARD added this to the 2022.7.0 milestone Jun 14, 2022
AxelRICHARD added a commit to AxelRICHARD/sirius-components that referenced this issue Jun 14, 2022
@AxelRICHARD
[1268] Use literal instead of name for Enum label & newValue
c267f7a 
Bug: eclipse-sirius#1268
Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
AxelRICHARD added a commit to AxelRICHARD/sirius-components that referenced this issue Jun 14, 2022
@AxelRICHARD
[1268] Use literal instead of name for Enum label & newValue
b49423e 
Bug: eclipse-sirius#1268
Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
AxelRICHARD added a commit to AxelRICHARD/sirius-components that referenced this issue Jun 15, 2022
@AxelRICHARD
[1268] Use literal instead of name for Enum label & newValue
7982611 
Bug: eclipse-sirius#1268
Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
gcoutable pushed a commit that referenced this issue Jun 15, 2022
@AxelRICHARD @gcoutable
[1268] Use literal instead of name for Enum label & newValue
38e1f3b 
Bug: #1268
Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
@sbegaudeau sbegaudeau linked a pull request Jun 24, 2022 that will close this issue
[1244] Add support for grid layout on FormDescriptions #1249
Merged
39 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AxelRICHARD AxelRICHARD

Labels
difficulty: medium type: bug
Projects
None yet
Milestone
2022.7.0
Development

Successfully merging a pull request may close this issue.

[1244] Add support for grid layout on FormDescriptions AxelRICHARD/sirius-components
2 participants
@sbegaudeau @AxelRICHARD