Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error state persists in contextual palette between independent uses #1250

Closed
4 tasks done
nvannr opened this issue Jun 7, 2022 · 0 comments · Fixed by #1267
Closed
4 tasks done

Error state persists in contextual palette between independent uses #1250

nvannr opened this issue Jun 7, 2022 · 0 comments · Fixed by #1267
Labels
difficulty: medium package: diagrams type: bug
Milestone
2022.9.0

Comments

@nvannr
Copy link
Contributor

nvannr commented Jun 7, 2022 •
edited
Loading

  • I have checked that this bug has not yet been reported by someone else
  • I have checked that this bug appears on Chrome
  • I have specified the version :
  • latest
  • I have specified my environment :
  • Windows

Screenshots

I am inducing an error in the palette by disabling the network before using a tool, after enabling the network again we can see that the palette is successfully fetched on different elements but the error still appears.

staging_palette_error.mp4

Steps to reproduce

  • Make the palette go into an error state
  • Invoke another palette

Expected behavior

In my opinion the error state should be lifted after the contextual palette is closed.

Actual behavior

The error state persists after opening a new palette.
@gcoutable gcoutable added this to the 2022.7.0 milestone Jun 7, 2022
nvannr added a commit to nvannr/sirius-components that referenced this issue Jun 14, 2022
@nvannr
[1250] Fixed invoke tool effect hooks dependencies
b42ad04 
Bug: eclipse-sirius#1250
Signed-off-by: Nicolas Vannier <nicolas.vannier@obeo.fr>
@nvannr nvannr mentioned this issue Jun 14, 2022
Merged
39 tasks
@sbegaudeau sbegaudeau linked a pull request Jun 20, 2022 that will close this issue
[1250] Fixed invoke tool effect hooks dependencies #1267
Merged
39 tasks
@sbegaudeau sbegaudeau modified the milestones: 2022.7.0, 2022.9.0 Jul 25, 2022
pcdavid pushed a commit to nvannr/sirius-components that referenced this issue Aug 30, 2022
@nvannr @pcdavid
[1250] Fixed invoke tool effect hooks dependencies
306e666 
Bug: eclipse-sirius#1250
Signed-off-by: Nicolas Vannier <nicolas.vannier@obeo.fr>
sbegaudeau pushed a commit to nvannr/sirius-components that referenced this issue Sep 1, 2022
@nvannr @sbegaudeau
[1250] Fixed invoke tool effect hooks dependencies
00c5323 
Bug: eclipse-sirius#1250
Signed-off-by: Nicolas Vannier <nicolas.vannier@obeo.fr>
sbegaudeau pushed a commit that referenced this issue Sep 1, 2022
@nvannr @sbegaudeau
[1250] Fixed invoke tool effect hooks dependencies
006df30 
Bug: #1250
Signed-off-by: Nicolas Vannier <nicolas.vannier@obeo.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty: medium package: diagrams type: bug
Projects
None yet
Milestone
2022.9.0
Development

Successfully merging a pull request may close this issue.

[1250] Fixed invoke tool effect hooks dependencies nvannr/sirius-components
3 participants
@sbegaudeau @gcoutable @nvannr