Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it possible to access to the request from a service #1019

Closed
1 task done
RaphaelPageObeo opened this issue Jan 26, 2022 · 0 comments · Fixed by #907
Closed
1 task done

Make it possible to access to the request from a service #1019

RaphaelPageObeo opened this issue Jan 26, 2022 · 0 comments · Fixed by #907
Labels
difficulty: medium type: enhancement
Milestone
2022.3.0

Comments

@RaphaelPageObeo
Copy link
Contributor

RaphaelPageObeo commented Jan 26, 2022 •
edited
Loading

  • I have checked that this feature has not yet been suggested by someone else.

Expected behavior

Some services will need to have access to the context of the request triggering their execution.
In order to do so, the ExecutorService of the EditingContextEventProcessor needs to wrap all of its tasks with the request.

Cuttings backs

Consumer of Sirius Components will have to provide the RequestAttributes in the RequestContextHolder to make the EditingContextEventProcessor work. It should be very easy for those in a Spring environment, but it is not free for those outside of a Spring environment.
@sbegaudeau sbegaudeau added this to the 2022.03.0 milestone Jan 26, 2022
RaphaelPageObeo added a commit to RaphaelPageObeo/sirius-components that referenced this issue Jan 26, 2022
@RaphaelPageObeo
[1019] Add access to the request context from the services
a713102 
Bug: eclipse-sirius#1019
Signed-off-by: Raphaël Pagé <raphael.page@obeo.fr>
@RaphaelPageObeo RaphaelPageObeo mentioned this issue Jan 26, 2022
Merged
8 tasks
RaphaelPageObeo added a commit to RaphaelPageObeo/sirius-components that referenced this issue Jan 26, 2022
@RaphaelPageObeo
[1019] Add access to the request context from the services
0b0a0eb 
Bug: eclipse-sirius#1019
Signed-off-by: Raphaël Pagé <raphael.page@obeo.fr>
@sbegaudeau sbegaudeau linked a pull request Feb 4, 2022 that will close this issue
[937] [938] [1019] Add diagram to SVG service #907
Merged
8 tasks
sbegaudeau pushed a commit that referenced this issue Feb 4, 2022
@RaphaelPageObeo @sbegaudeau
[1019] Add access to the request context from the services
f96e720 
Bug: #1019
Signed-off-by: Raphaël Pagé <raphael.page@obeo.fr>
sbegaudeau pushed a commit that referenced this issue Feb 4, 2022
@RaphaelPageObeo @sbegaudeau
[1019] Add access to the request context from the services
5432f95 
Bug: #1019
Signed-off-by: Raphaël Pagé <raphael.page@obeo.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty: medium type: enhancement
Projects
None yet
Milestone
2022.3.0
Development

Successfully merging a pull request may close this issue.

[937] [938] [1019] Add diagram to SVG service RaphaelPageObeo/sirius-components
2 participants
@sbegaudeau @RaphaelPageObeo