Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrolling continues unexpectedly #179

Open
hendeltom opened this issue Mar 18, 2024 · 5 comments
Open

Scrolling continues unexpectedly #179

hendeltom opened this issue Mar 18, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@hendeltom
Copy link

Scenario:

  1. Pick a slider's thumb with the mouse and start scrolling
  2. leave the area of the RAP application (move the mouse cursor out of the the browser tab's body area) while the mouse button is still pressed
  3. release the mouse button outside of the RAP application
  4. move the mouse cursor back into the RAP application without any mouse button pressed

--> the slider immediately starts to react to mouse movements even that no mouse button is pressed;
you have to click somewhere in the RAP application to stop scrolling.

@hendeltom
Copy link
Author

The problem is IMHO in AbstractSlider._onThumbMouseMove() (AbstractSlider.js, line 249)
It lacks a check whether or not the main mouse button is pressed; and if that's not the case the scrolling operation should terminate as AbstractSlider._onMouseUp() does.

@ifurnadjiev
Copy link
Contributor

I'll take a look if button check in AbstractSlider._onThumbMouseMove() will solve the problem.

@hendeltom
Copy link
Author

I've cloned the RAP repo and committed a change to my clone - see hendeltom@45a47ec

If that's ok for you I could create a PR from this. Btw., ECA is signed :-)

@ifurnadjiev
Copy link
Contributor

Yes... Please create a PR.

@hendeltom
Copy link
Author

I've just created the PR - #180. How's the reviewer assigned?

@mknauer mknauer added the bug Something isn't working label Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants