Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client side receive maximum #2

Open
alsm opened this issue Nov 2, 2018 · 1 comment
Open

Client side receive maximum #2

alsm opened this issue Nov 2, 2018 · 1 comment

Comments

@alsm
Copy link
Contributor

alsm commented Nov 2, 2018

http://docs.oasis-open.org/mqtt/mqtt/v5.0/cs02/mqtt-v5.0-cs02.html#_Toc514345321

The library supports the server side receive maximum, using a weighted semaphore to ensure that we do not have more inflight messages than the server allows, there is not yet any checking in the client to ensure that if a receive maximum was set by the client the server has not broken it. Although there is a field in the client called clientInflight declared as a weighted semaphore, this might not be the best method of tracking this (perhaps just an atomic counter?)

@alsm alsm changed the title Support client side receive maximum Client side receive maximum Nov 2, 2018
@vishnureddy17
Copy link
Contributor

Just wanted to note that I don't think client-side receive maximum is meaningful unless the user has manual acknowledgements enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants