From bd2ff117a69db40d7eb1f073ea658711f1a253a9 Mon Sep 17 00:00:00 2001 From: Peter Bain Date: Thu, 12 Jul 2018 16:04:59 -0400 Subject: [PATCH] Fix module version comparison Convert expected and actual modules to strings before comparing Signed-off-by: Peter Bain --- .../org/openj9/test/stackWalker/StackWalkerTest.java | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/test/functional/Java9andUp/src_latest/org/openj9/test/stackWalker/StackWalkerTest.java b/test/functional/Java9andUp/src_latest/org/openj9/test/stackWalker/StackWalkerTest.java index ec3f34a1fad..0efd027ad53 100644 --- a/test/functional/Java9andUp/src_latest/org/openj9/test/stackWalker/StackWalkerTest.java +++ b/test/functional/Java9andUp/src_latest/org/openj9/test/stackWalker/StackWalkerTest.java @@ -260,15 +260,18 @@ private void dumpModules() { if (null != d) { StackTraceElement e = f.toStackTraceElement(); String modName = d.name(); + String expectedName = e.getModuleName(); if (null != modName) { - assertEquals(modName, e.getModuleName(), "Wrong module name"); + assertEquals(modName, expectedName, "Wrong module name"); } Optional modVersion = d.version(); if (modVersion.isPresent()) { - assertEquals(modVersion.get(), e.getModuleVersion(), "Wrong module version"); + String actualVersion = modVersion.get().toString(); + String expectedVersion = e.getModuleVersion(); + assertEquals(actualVersion, expectedVersion, "Wrong module version"); } if (f.getDeclaringClass() == Thread.class) { - assertEquals("java.base", e.getModuleName(), "Wrong module name"); + assertEquals("java.base", expectedName, "Wrong module name"); } } }