-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix formatting in jvm.c #20547
Open
ThanHenderson
wants to merge
1
commit into
eclipse-openj9:master
Choose a base branch
from
ThanHenderson:init-arg-scan-clean
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix formatting in jvm.c #20547
ThanHenderson
wants to merge
1
commit into
eclipse-openj9:master
from
ThanHenderson:init-arg-scan-clean
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keithc-ca
requested changes
Nov 8, 2024
ThanHenderson
force-pushed
the
init-arg-scan-clean
branch
from
November 12, 2024 15:04
dac2998
to
22a3090
Compare
ThanHenderson
changed the title
Clean up initialArgumentScan and remove whitespace from jvm.c
Fix formatting in jvm.c
Nov 12, 2024
ThanHenderson
force-pushed
the
init-arg-scan-clean
branch
from
November 12, 2024 15:11
22a3090
to
d7da2da
Compare
@keithc-ca I've addressed more issues in the file. Let me know if you catch anything I missed, or catch anything that shouldn't have been touched. Much of this change was automated, and it is possible that something was altered in a way it shouldn't have been. I believe I've caught most of those, but some may have slipped by. |
keithc-ca
requested changes
Nov 20, 2024
ThanHenderson
force-pushed
the
init-arg-scan-clean
branch
3 times, most recently
from
November 28, 2024 15:11
d80fdd0
to
acfd343
Compare
keithc-ca
requested changes
Nov 28, 2024
Signed-off-by: Nathan Henderson <nathan.henderson@ibm.com>
ThanHenderson
force-pushed
the
init-arg-scan-clean
branch
from
November 29, 2024 18:11
acfd343
to
494789d
Compare
Please address the merge conflict. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nathan Henderson nathan.henderson@ibm.com