Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate platform specific isX86 check in codegen agnostic Recognized Call Transformer #1374

Closed
fjeremic opened this issue Mar 7, 2018 · 1 comment
Labels

Comments

@fjeremic
Copy link
Contributor

fjeremic commented Mar 7, 2018

As part of [1] there seems to be a x86 specific check introduced in a codegen agnostic transformation. The reason the check exists is because the Z codegen currently pattern matches the direct calls at direct call evaluator time and inlines these toUpper and toLower methods. We should switch to using the common Recognized Call Transformer infrastructure for Z and eliminate these platform agnostic checks.

There also seems to be another isX86() check in the same file for Math.min acceleration. We should try to get rid of this one as well. No reason why this shouldn't be done on all platforms.

[1] #1366 (review)

@fjeremic
Copy link
Contributor Author

This was completed as part of #2320.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant