Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EDGAR should read Setup-String interactively #317

Open
Tracked by #91
mbfm opened this issue Dec 3, 2024 · 2 comments
Open
Tracked by #91

EDGAR should read Setup-String interactively #317

mbfm opened this issue Dec 3, 2024 · 2 comments
Labels
component: edgar Mostly related to EDGAR. type: enhancement Fulfills a need or requirement by improving an existing functionality.

Comments

@mbfm
Copy link
Contributor

mbfm commented Dec 3, 2024

Currently, running the EDGAR Setup is done by passing the Setup-String via the CLI:

./opendut-edgar setup managed $SETUP_STRING

This should be read via stdin, so the user will only enter

./opendut-edgar setup managed

Then get a printed explanation of where to retrieve this setup string from, and then they paste it into the interactive dialog.

This ensures that the Setup-String does not end up in the command-line history and provides a better user experience.

For non-interactive use, it should be possible to pipe the Setup-String into EDGAR from a file like this:

cat setup_string.txt | ./opendut-edgar setup managed
@mbfm mbfm added this to openDuT Dec 3, 2024
@mbfm mbfm converted this from a draft issue Dec 3, 2024
@mbfm mbfm added component: edgar Mostly related to EDGAR. type: enhancement Fulfills a need or requirement by improving an existing functionality. labels Dec 3, 2024
@mbfm mbfm mentioned this issue Dec 3, 2024
7 tasks
@reimarstier
Copy link
Contributor

The fallback option voluntarily opens this issue again and should be rather discouraged. What about if EDGAR reads the configuration from file?

@mbfm
Copy link
Contributor Author

mbfm commented Jan 30, 2025

Good point, I changed the issue text to read from a file instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: edgar Mostly related to EDGAR. type: enhancement Fulfills a need or requirement by improving an existing functionality.
Projects
Status: Backlog
Development

No branches or pull requests

2 participants