From 395fd44107ef8e55745d43c529045ddbfab08e51 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Frank=20M=C3=A4rkle?= <Frank.Maerkle@mercedes-benz.com>
Date: Mon, 13 Jan 2025 08:46:10 +0100
Subject: [PATCH] CARL-API -> Deprecate device_interfaces field in
 OldPeerConfiguration.

---
 opendut-carl/src/cluster/manager.rs                     | 3 +++
 opendut-types/proto/opendut/types/cluster/cluster.proto | 2 +-
 opendut-types/src/cluster/assignment.rs                 | 1 +
 opendut-types/src/proto/cluster.rs                      | 2 ++
 tests/src/peer_configuration.rs                         | 4 ++++
 5 files changed, 11 insertions(+), 1 deletion(-)

diff --git a/opendut-carl/src/cluster/manager.rs b/opendut-carl/src/cluster/manager.rs
index d2afac9f5..a99aac856 100644
--- a/opendut-carl/src/cluster/manager.rs
+++ b/opendut-carl/src/cluster/manager.rs
@@ -320,6 +320,8 @@ impl ClusterManager {
                                     Err(DeployClusterError::Internal { cluster_id, cause: message })
                                 }
                             };
+
+                            #[expect(deprecated)]
                             vpn_address.map(|vpn_address|
                                 PeerClusterAssignment { peer_id, vpn_address, can_server_port, device_interfaces }
                             )
@@ -548,6 +550,7 @@ mod test {
             assert_that!(fixture.testee.lock().await.deploy_cluster(cluster_id).await, ok(eq(&())));
 
 
+            #[expect(deprecated)]
             let assert_cluster_assignment_valid = |cluster_assignment: &ClusterAssignment| {
                 assert_that!(
                     cluster_assignment,
diff --git a/opendut-types/proto/opendut/types/cluster/cluster.proto b/opendut-types/proto/opendut/types/cluster/cluster.proto
index f5f0ad6db..f92a0f293 100644
--- a/opendut-types/proto/opendut/types/cluster/cluster.proto
+++ b/opendut-types/proto/opendut/types/cluster/cluster.proto
@@ -41,7 +41,7 @@ message PeerClusterAssignment {
   opendut.types.peer.PeerId peer_id = 1;
   opendut.types.util.IpAddress vpn_address = 2;
   opendut.types.util.Port can_server_port = 3;
-  repeated opendut.types.util.NetworkInterfaceDescriptor device_interfaces = 4;
+  repeated opendut.types.util.NetworkInterfaceDescriptor device_interfaces = 4;  //deprecated since 0.5.0
 }
 // ANCHOR_END: PeerClusterAssignment
 
diff --git a/opendut-types/src/cluster/assignment.rs b/opendut-types/src/cluster/assignment.rs
index 0c7c69a27..7d5371eb1 100644
--- a/opendut-types/src/cluster/assignment.rs
+++ b/opendut-types/src/cluster/assignment.rs
@@ -17,5 +17,6 @@ pub struct PeerClusterAssignment {
     pub peer_id: PeerId,
     pub vpn_address: IpAddr,
     pub can_server_port: Port,
+    #[deprecated(since="0.5.0", note="Use PeerConfiguration::device_interfaces instead.")]
     pub device_interfaces: Vec<NetworkInterfaceDescriptor>,
 }
diff --git a/opendut-types/src/proto/cluster.rs b/opendut-types/src/proto/cluster.rs
index af4610e1d..2346e0cc1 100644
--- a/opendut-types/src/proto/cluster.rs
+++ b/opendut-types/src/proto/cluster.rs
@@ -226,6 +226,7 @@ impl From<crate::cluster::PeerClusterAssignment> for PeerClusterAssignment {
             peer_id: Some(value.peer_id.into()),
             vpn_address: Some(value.vpn_address.into()),
             can_server_port: Some(value.can_server_port.into()),
+            #[expect(deprecated)]
             device_interfaces: value.device_interfaces.into_iter().map(Into::into).collect(),
         }
     }
@@ -253,6 +254,7 @@ impl TryFrom<PeerClusterAssignment> for crate::cluster::PeerClusterAssignment {
             .map(TryInto::try_into)
             .collect::<Result<_, _>>()?;
 
+        #[expect(deprecated)]
         Ok(Self {
             peer_id,
             vpn_address,
diff --git a/tests/src/peer_configuration.rs b/tests/src/peer_configuration.rs
index bb3b5bd7b..10cc67a6e 100644
--- a/tests/src/peer_configuration.rs
+++ b/tests/src/peer_configuration.rs
@@ -69,6 +69,8 @@ async fn carl_should_send_peer_configurations_in_happy_flow() -> anyhow::Result<
             }));
             Ok::<_, anyhow::Error>(())
         };
+
+        #[expect(deprecated)]
         let validate_old_peer_configuration = |old_peer_configuration: OldPeerConfiguration| {
             assert_that!(old_peer_configuration, matches_pattern!(OldPeerConfiguration {
                 cluster_assignment: some(matches_pattern!(ClusterAssignment {
@@ -164,6 +166,8 @@ async fn carl_should_send_cluster_related_peer_configuration_if_a_peer_comes_onl
             }));
             Ok::<_, anyhow::Error>(())
         };
+
+        #[expect(deprecated)]
         let validate_old_peer_configuration = |old_peer_configuration: OldPeerConfiguration| {
             assert_that!(old_peer_configuration, matches_pattern!(OldPeerConfiguration {
                 cluster_assignment: some(matches_pattern!(ClusterAssignment {