Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JGit should support X.509 signed commits #49

Open
lucamilanesio opened this issue Apr 15, 2024 · 2 comments
Open

JGit should support X.509 signed commits #49

lucamilanesio opened this issue Apr 15, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@lucamilanesio
Copy link
Member

lucamilanesio commented Apr 15, 2024

Description

JGit should support X.509 signed commits

Motivation

Companies have official X.509 certificates and they should be able to leverage existing certified identities

Alternatives considered

JGit could leverage an external process like smimesign by spawning a process. However, that would have a detriment effect on the overall system load and latency.

Additional context

C-Git supports signed X.509 commits, therefore JGit servers (e.g. Gerrit) will have to deal with those signatures anyway.

@msohn msohn added the enhancement New feature or request label Apr 15, 2024
@lucamilanesio
Copy link
Member Author

@msohn by looking at BitBucket DataCentre 8.15 JGit should already support this, as BitBucket DataCentre is based on JGit. Am I mistaken?

@lucamilanesio
Copy link
Member Author

lucamilanesio commented Apr 18, 2024

@DanieleSassoli provided an initial implementation with Change eclipse-jgit/jgit/+/1193188 @msohn @tomaswolf what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants