Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't expose implementation details in shm name #439

Closed
elBoberido opened this issue Dec 16, 2020 · 1 comment · Fixed by #1053
Closed

Don't expose implementation details in shm name #439

elBoberido opened this issue Dec 16, 2020 · 1 comment · Fixed by #1053
Assignees
Labels
refactoring Refactor code without adding features
Milestone

Comments

@elBoberido
Copy link
Member

Brief feature description

Currently the SharedMemory expects a name with a leading slash. This is an implementation detail and should be removed.

Detailed information

The name of the shared memory is defined in an upper layer of the stack and then passed down to the SharedMemory object. If the implementation changes or a different mechanism is used, the leading slash might be a problem. Since this is an implementation detail of SharedMemory the slash should be added in that class.

@elBoberido elBoberido added the refactoring Refactor code without adding features label Dec 16, 2020
@elBoberido elBoberido added this to the Prio 3 milestone Dec 16, 2020
@elBoberido elBoberido self-assigned this Dec 16, 2020
@elBoberido elBoberido assigned dkroenke and unassigned elBoberido Dec 16, 2020
@elBoberido
Copy link
Member Author

@dkroenke just as a hint since I looked that up yesterday. In the segment_manager.inl a slash is added to the shm name. Except that, I think it's only /iceoryx_mgmt and in some tests where the slash is in the name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Refactor code without adding features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants