https://github.com/eclipse-ee4j/faces-api/issues/1570

BalusC · BalusC · commit 8c3f3ce4c3d3 · 2021-11-08T12:16:16.000-04:00
SameSite value should be String not Boolean
diff --git a/impl/src/main/java/com/sun/faces/context/ExternalContextImpl.java b/impl/src/main/java/com/sun/faces/context/ExternalContextImpl.java
@@ -795,7 +795,7 @@ public void addResponseCookie(String name, String value, Map<String, Object> pro
                     cookie.setHttpOnly((Boolean) v);
                     break;
                 case SameSite:
-                    cookie.setAttribute("SameSite", (Boolean) v);
+                    cookie.setAttribute("SameSite", (String) v);
                 default:
                     throw new IllegalStateException(); // shouldn't happen
                 }
diff --git a/impl/src/main/java/jakarta/faces/context/ExternalContext.java b/impl/src/main/java/jakarta/faces/context/ExternalContext.java
@@ -190,7 +190,7 @@ public abstract class ExternalContext {
      *
      * <td>SameSite</td>
      *
-     * <td>Boolean</td>
+     * <td>String</td>
      *
      * <td>setAttribute</td>
      *

Original file line number	Diff line number	Diff line change
`@@ -795,7 +795,7 @@ public void addResponseCookie(String name, String value, Map<String, Object> pro`
`795`	`795`	`cookie.setHttpOnly((Boolean) v);`
`796`	`796`	`break;`
`797`	`797`	`case SameSite:`
`798`		`- cookie.setAttribute("SameSite", (Boolean) v);`
	`798`	`+ cookie.setAttribute("SameSite", (String) v);`
`799`	`799`	`default:`
`800`	`800`	`throw new IllegalStateException(); // shouldn't happen`
`801`	`801`	`}`
Original file line number	Diff line number	Diff line change
`@@ -190,7 +190,7 @@ public abstract class ExternalContext {`
`190`	`190`	`*`
`191`	`191`	`* <td>SameSite</td>`
`192`	`192`	`*`
`193`		`- * <td>Boolean</td>`
	`193`	`+ * <td>String</td>`
`194`	`194`	`*`
`195`	`195`	`* <td>setAttribute</td>`
`196`	`196`	`*`