Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jetty connector does not support per request read timeout #4405

Closed
smalesev opened this issue Mar 2, 2020 · 0 comments · Fixed by #4415
Closed

Jetty connector does not support per request read timeout #4405

smalesev opened this issue Mar 2, 2020 · 0 comments · Fixed by #4415

Comments

@smalesev
Copy link

smalesev commented Mar 2, 2020 •
edited
Loading

JettyConnector: translateRequest makes a call to get readtimeout as below

final Object readTimeout = clientRequest.getConfiguration().getProperties().get(ClientProperties.READ_TIMEOUT);

This means that readtimout is always coming from Client and is not set per request (invocation). I think correct thing to do is

final int socketTimeout = clientRequest.resolveProperty(ClientProperties.READ_TIMEOUT, -1);

this would pick request scope value

The same issue applies to Netty connector as well
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use request scope ClientProperties.READ_TIMEOUT in Jetty && Netty jansupol/jersey
1 participant
@smalesev