Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proper tests with JDK9+ modules #35

Closed
jbescos opened this issue Oct 14, 2022 · 0 comments · Fixed by #36
Closed

Add proper tests with JDK9+ modules #35

jbescos opened this issue Oct 14, 2022 · 0 comments · Fixed by #36

Comments

@jbescos
Copy link
Member

jbescos commented Oct 14, 2022

Is your feature request related to a problem? Please describe.
Many new issues are coming because of JDK9+ modules. In my opinion we don't have a proper tests to verify/reproduce issues. Normally I have to create my own separate project to test this.

Describe the solution you'd like
I would like to have separate maven modules for testing purposes. In mail we should have few of them, because some apps are using the jakarta-mail bundle, and others not.

These new maven modules should have a src/java/main/module-info.java with a module name not related to jakarta.mail or com.sun.mail. For example: com.app.example.

In src/java/test we should add some simple tests to make sure there are no module issues.

@jbescos jbescos changed the title Enhance tests with JDK9+ modules Add proper tests with JDK9+ modules Oct 14, 2022
@lukasj lukasj linked a pull request Nov 2, 2022 that will close this issue
@lukasj lukasj closed this as completed in #36 Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant